-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DNM: test pulumi update #429
Conversation
Signed-off-by: Hayden B <hblauzvern@google.com>
🍹
|
So the result seems to be that every Branch Protection gets this addition:
I will review some specific projects to see if the |
To my best understanding these are correct:
I'm still baffled by how we only get an added pushAllowances but nothing was removed... What happened to the the I wish there was a way to deploy this to one or two projects first :) |
We could make the change in the conformance org which would only affect one project. |
I keep re-reading this and I'm not sure if it can be true. What does the "restrict who can push" checkbox even mean at this point? It seems the checkbox actually means "allow more people to push" instead of "restrict who can push"? the docs on all sides are kind of bad but this would actually be in line with the new argument name: |
I've got a possible branch in https://github.com/jku/github-sync/tree/tweak-push-restrictions: it tries to avoid setting restrictPushes at all if the list is empty. I assume this is the equivalent of not checking the checkbox at all. You could modify |
That sounds correct to me, and your fix SGTM. From what I understand, the difference is that those with |
@jku reran based on merged sync PR |
So no change from the github-sync PR merge...
|
Created #434 so that we (we = TSC or anyone who's a maintainer on this repo) can manually run This SDK bump seems safe, though we'll try in the conformance org first. |
Summary
Release Note
Documentation