Tweak how push restrictions are handled #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To avoid unnecessary churn in sigstore/community, only set RestrictPushes if the project has users in the pushRestrictions list. Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
jku
force-pushed
the
tweak-push-restrictions
branch
from
d459432 to
7f107f2
Compare
haydentherapper
approved these changes
Apr 19, 2024
|
I'm marking this ready-for-review: if you think it's worth testing I guess we just have to merge to main to to see how it goes :( The reason I'm a bit hesitant is that while this probably does the right thing with current sigstore/community contents it does smell a bit: restrictPushes probably shouldn't only apply if the list of push exceptions (which our pushrestrictions really seem to be) list is longer than 0... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft while discussion is ongoing, see sigstore/community#429
To avoid unnecessary churn in sigstore/community only set RestrictPushes if the project has users in the pushRestrictions list.