Clarify error when KMS provider fails to load #2220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2220 +/- ##
==========================================
+ Coverage 26.51% 26.62% +0.11%
==========================================
Files 131 131
Lines 7671 7680 +9
==========================================
+ Hits 2034 2045 +11
Misses 5376 5376
+ Partials 261 259 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Before:
$ KEY_REF=gcpkms://projects/test/locations/global/keyRings/test/cryptoKeys/mykey/cryptoKeyVersions/1
$ cosign verify-blob --key $KEY_REF --signature /dev/null /dev/null
Error: verifying blob [/dev/null]: loading public key: loading URL: unrecognized scheme: gcpkms://
main.go:62: error during command execution: verifying blob [/dev/null]: loading public key: loading URL: unrecognized scheme: gcpkms://
After:
$ KEY_REF=gcpkms://projects/test/locations/global/keyRings/test/cryptoKeys/mykey/cryptoKeyVersions/1
$ cosign verify-blob --key $KEY_REF --signature /dev/null /dev/null
Error: verifying blob [/dev/null]: loading public key: new gcp kms client: google: could not find default credentials. See https://developers.google.com/accounts/docs/application-default-credentials for more information.
main.go:62: error during command execution: verifying blob [/dev/null]: loading public key: new gcp kms client: google: could not find default credentials. See https://developers.google.com/accounts/docs/application-default-credentials for more information.
Addresses sigstore#2094; I'm not sure if this fixes it, but it'll give us more
information.
Signed-off-by: Zachary Newman <z@znewman.net>
znewman01
force-pushed
the
bettererror
branch
from
9a39443
to
cee72e1
Compare
dlorenc
approved these changes
Sep 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After:
Addresses #2094; I'm not sure if this fixes it, but it'll give us more
information.
Signed-off-by: Zachary Newman z@znewman.net
Summary
Release Note
Documentation