Consolidate viper usage in pkg/ca/ca.go
#255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using `viper` (like flags, logging) insider of libraries is a bit of a code smell, so I started to look at where we were using viper directly, and started threading particular bits of configuration through as params, which seems to be the most natural way to do this in most contexts. Right now there is still a big wad of usage in `pkg/ca/ca.go`, which I'm going to start looking into next, but at least the remainder have been eliminated. Signed-off-by: Matt Moore <mattmoor@chainguard.dev>
dekkagaijin
approved these changes
Dec 2, 2021
Merged
dlorenc
approved these changes
Dec 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
viper(like flags, logging) insider of libraries is a bit of a code smell, so I started to look at where we were using viper directly, and started threading particular bits of configuration through as params, which seems to be the most natural way to do this in most contexts.Right now there is still a big wad of usage in
pkg/ca/ca.go(almost entirely inCA()), which I'm going to start looking into next, but at least the remainder have been eliminated. 💥Signed-off-by: Matt Moore mattmoor@chainguard.dev
Ticket Link
N/A
Release Note