Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate viper usage in pkg/ca/ca.go #255

Merged
merged 1 commit into from
Dec 2, 2021

Commits on Dec 2, 2021

  1. Consolidate viper usage in pkg/ca/ca.go

    Using `viper` (like flags, logging) insider of libraries is a bit of a code smell, so I started to look at where we were using viper directly, and started threading particular bits of configuration through as params, which seems to be the most natural way to do this in most contexts.
    
    Right now there is still a big wad of usage in `pkg/ca/ca.go`, which I'm going to start looking into next, but at least the remainder have been eliminated.
    
    Signed-off-by: Matt Moore <mattmoor@chainguard.dev>
    mattmoor committed Dec 2, 2021
    Configuration menu
    Copy the full SHA
    10d8891 View commit details
    Browse the repository at this point in the history