Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for OIDC configuration and tokens #467

Merged
merged 1 commit into from
Mar 11, 2022

Conversation

haydentherapper
Copy link
Contributor

@haydentherapper haydentherapper commented Mar 9, 2022

This outlines what is required for each OIDC issuer and how the
OIDC claims are used in the issued certificates.

username and uri flows are under review - #455 and #463

Signed-off-by: Hayden Blauzvern hblauzvern@google.com

Summary

Ticket Link

Fixes

Release Note


@codecov-commenter
Copy link

codecov-commenter commented Mar 9, 2022

Codecov Report

Merging #467 (c078013) into main (6eba74e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #467   +/-   ##
=======================================
  Coverage   45.66%   45.66%           
=======================================
  Files          14       14           
  Lines         957      957           
=======================================
  Hits          437      437           
  Misses        460      460           
  Partials       60       60           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6eba74e...c078013. Read the comment docs.

This outlines what is required for each OIDC issuer and how the
OIDC claims are used in the issued certificates.

Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
Copy link
Member

@loosebazooka loosebazooka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome. Just curious: are username and uri based oauth tokens allowed to be configured by fulcio?

@haydentherapper
Copy link
Contributor Author

Ah yes, that's cause those are incoming changes - #455 and #463

I'll update the PR description to note that.

@dlorenc dlorenc merged commit e88278c into sigstore:main Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants