Update Username OIDC flow based on comments #463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haydentherapper
force-pushed
the
uri-with-subject
branch
3 times, most recently
from
3c373e5
to
9029402
Compare
|
cc @znewman01 |
Merged
znewman01
approved these changes
Mar 18, 2022
|
Whoops, #483 submitted the change too. I'll rebase and update based on the comments. |
Oh wow, somehow I only saw the second commit there with the tests. |
haydentherapper
force-pushed
the
uri-with-subject
branch
from
9029402
to
b2186c0
Compare
Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
haydentherapper
changed the title
|
All looks great! |
Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
dlorenc
approved these changes
Mar 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Signed-off-by: Hayden Blauzvern hblauzvern@google.com
Ticket Link
Fixes #398
Release Note