Refactor API tests #483
Merged
Refactor API tests #483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implements the second part of sigstore#398, adding support for OIDC subjects that are simply usernames. A configured domain will be appended to the username and included as a SAN email address. Like sigstore#455, token issuers must partially match the configured domain. The top level and second level domain must match, and it's expected that we validate ownership for what's configured in the issuer and domain fields. Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
This refactor adds tests for all supported OIDC types, and makes it simpler to add new tests for new OIDC types. * Add tests for K8s and GitHub OIDC types. * Add additional verification for issued certificate values * Add dedicated test for RootCert success, don't call RootCert in every test. * Move common expectations to function. This provides a single place to check response values. * Move common set up to dedicated functions. * Lowercase all error messages, because style. Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
Codecov Report
@@ Coverage Diff @@
## main #483 +/- ##
==========================================
+ Coverage 46.87% 47.63% +0.75%
==========================================
Files 14 14
Lines 1024 1056 +32
==========================================
+ Hits 480 503 +23
- Misses 476 480 +4
- Partials 68 73 +5
Continue to review full report at Codecov.
|
dlorenc
approved these changes
Mar 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This refactor adds tests for all supported OIDC types, and makes it
simpler to add new tests for new OIDC types.
check response values.
Once #463 is submitted, I'll rebase.
Signed-off-by: Hayden Blauzvern hblauzvern@google.com
Ticket Link
Fixes
Release Note