Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEP PHP Support in CMS5 #38

Merged
merged 2 commits into from
Jan 18, 2023
Merged

DEP PHP Support in CMS5 #38

merged 2 commits into from
Jan 18, 2023

Conversation

sabina-talipova
Copy link
Contributor

@sabina-talipova sabina-talipova mentioned this pull request Dec 12, 2022
Closed
3 tasks
@sabina-talipova sabina-talipova force-pushed the pulls/2/upgrade-cms5 branch 2 times, most recently from 3421e47 to 0f8aaea Compare December 18, 2022 23:01
@sabina-talipova
Copy link
Contributor Author

sabina-talipova commented Dec 22, 2022 •
edited
Loading

Requires

@sabina-talipova
Copy link
Contributor Author

sabina-talipova commented Jan 15, 2023 •
edited by emteknetnz
Loading

Requires to merge first

@emteknetnz
Copy link
Member

Requires silverstripe/silverstripe-frameworktest#135 to be merged first

@emteknetnz emteknetnz force-pushed the pulls/2/upgrade-cms5 branch from 5c78833 to 2ed6ff4 Compare January 18, 2023 02:37
@emteknetnz emteknetnz force-pushed the pulls/2/upgrade-cms5 branch from 2ed6ff4 to b3f04a6 Compare January 18, 2023 02:40
@emteknetnz
Copy link
Member

Requires silverstripe/silverstripe-spamprotection#89

GuySartorelli
GuySartorelli approved these changes Jan 18, 2023
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, we're keeping widgets? That's gonna be one of the first to go once we have a good process for dropping support for modules.

Note for anyone looking at this: We are dropping support for akismet.

@GuySartorelli GuySartorelli merged commit 3ccd5a3 into silverstripe:2 Jan 18, 2023
@GuySartorelli GuySartorelli deleted the pulls/2/upgrade-cms5 branch January 18, 2023 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sabina-talipova @emteknetnz @GuySartorelli