NEW Add NullSpamProtector #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 18, 2023
GuySartorelli
requested changes
Jan 18, 2023
composer.json
Outdated
| @@ -20,7 +20,8 @@ | |||
| "silverstripe/cms": "^5", | |||
| "guzzlehttp/guzzle": "^7.5", | |||
| "fzaninotto/faker": "^1.9.2", | |||
| "silverstripe/vendor-plugin": "^2" | |||
| "silverstripe/vendor-plugin": "^2", | |||
| "silverstripe/spamprotection": "^4" | |||
There was a problem hiding this comment.
Let's not just arbitrarily add that module - use if (class_exists) to only declare the class if it's needed.
emteknetnz
force-pushed
the
pulls/1/null-spam-protector
branch
from
5d1eef6 to
54a54cf
Compare
emteknetnz
force-pushed
the
pulls/1/null-spam-protector
branch
from
54a54cf to
5afed61
Compare
GuySartorelli
approved these changes
Jan 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue silverstripe/silverstripe-framework#10402
This is required because we no longer support https://github.com/silverstripe/silverstripe-akismet/ which means there is no longer a default spam protector for recipes which had previously included it.
Create 1.1 branch and tag 1.1.0 after mergingLeave as 1.x-dev for now