-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMS 5: Fix broken JavaScript tests #1421
Comments
GuySartorelli
changed the title
Fix broken JavaScript tests
CMS 5: Fix broken JavaScript tests
Dec 13, 2022
This was referenced Dec 13, 2022
2 tasks
This was referenced Jan 20, 2023
This was referenced Feb 8, 2023
Linked PRs have been merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In some modules, javascript tests are broken after #1312
For those modules, I removed the
yarn test
command fromyarn build
so that the resources can be built.The tests must be fixed and passing, then
yarn test
must be added back into theyarn build
command.Use #1389 as an example of some changes you may need and acceptable workarounds (e.g. resorting to react 16 for tests, for now)
Acceptance Criteria
yarn test
runs without failures on all modulesyarn test
is added back into theyarn build
commandPRs
The text was updated successfully, but these errors were encountered: