Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMS 5: Fix broken JavaScript tests #1421

Closed
2 tasks done
GuySartorelli opened this issue Dec 13, 2022 · 1 comment
Closed
2 tasks done

CMS 5: Fix broken JavaScript tests #1421

GuySartorelli opened this issue Dec 13, 2022 · 1 comment

Comments

@GuySartorelli
Copy link
Member

GuySartorelli commented Dec 13, 2022

In some modules, javascript tests are broken after #1312
For those modules, I removed the yarn test command from yarn build so that the resources can be built.

The tests must be fixed and passing, then yarn test must be added back into the yarn build command.
Use #1389 as an example of some changes you may need and acceptable workarounds (e.g. resorting to react 16 for tests, for now)

Acceptance Criteria

  • yarn test runs without failures on all modules
  • yarn test is added back into the yarn build command

PRs

@GuySartorelli GuySartorelli changed the title Fix broken JavaScript tests CMS 5: Fix broken JavaScript tests Dec 13, 2022
@emteknetnz emteknetnz self-assigned this Jan 12, 2023
@GuySartorelli GuySartorelli removed their assignment Feb 9, 2023
@emteknetnz emteknetnz self-assigned this Feb 13, 2023
@emteknetnz
Copy link
Member

Linked PRs have been merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants