SS5: Remove trailing slash from SiteTree links if no action present #2771
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change helps normalising and canonicalisation of URLs. This picks up #2631 again for SS5.
SiteTree::RelativeLink()
is currently the only place in SS where a trailing slash is added to a URL when there is no$action
parameter given.Controller::join_links()
already adds slashes between sections of the path, the explicit slash inRelativeLink()
is not needed.Classes that don't use
Controller::join_links()
at all, e.g. https://github.com/silverstripe/silverstripe-framework/blob/4/src/ORM/PaginatedList.php#L446-L453 use the current request, which never has a trailing slash.Parent issue