Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEP Upgrade build stack #248

Merged
merged 4 commits into from
Dec 18, 2022

Conversation

GuySartorelli
Copy link
Member

@GuySartorelli GuySartorelli force-pushed the pulls/2/build-stack branch 3 times, most recently from d0262e6 to 62749a6 Compare November 22, 2022 01:36
@GuySartorelli GuySartorelli force-pushed the pulls/2/build-stack branch 3 times, most recently from ad05ced to 7c1f375 Compare December 7, 2022 03:24
@GuySartorelli GuySartorelli marked this pull request as ready for review December 13, 2022 00:11
@GuySartorelli
Copy link
Member Author

Check the comments in silverstripe/silverstripe-admin#1389 before reviewing this PR, as it will explain some of the changes made here.

@GuySartorelli
Copy link
Member Author

behat tests are allowed to fail at Max's request - we'll fix those up after all of the related PRs are merged.
JS CI build failed due to broken tests and linting errors. Those will also be handled separately, see silverstripe/silverstripe-admin#1421 and silverstripe/silverstripe-admin#1411

@emteknetnz emteknetnz merged commit 708e384 into silverstripe:2 Dec 18, 2022
@emteknetnz emteknetnz deleted the pulls/2/build-stack branch December 18, 2022 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants