FIX Rename exposed url module to node-url to avoid API clash #1019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Browsers already have a URL key on their window object, so this clashes with the expose-loader entry and makes it unusable.
robbieaverill
approved these changes
Mar 6, 2020
|
You probably need to tag/release/update webpack-config in this PR as well? |
|
Just published a new version of webpack-config. We'll probably need to bump which version of we're using on this PR. |
maxime-rainville
approved these changes
Apr 24, 2020
|
Merge on green |
dhensby
approved these changes
Apr 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Browsers already have a
URLkey on theirwindowobject, so this clashes with the expose-loader entry and makes it unusable.Pairs with an adjustment to the externals config in
@silverstripe/webpack-config: silverstripe/webpack-config#44