FIX Rename 'url' to 'node-url' to resolve browser API conflict #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robbieaverill
approved these changes
Mar 6, 2020
maxime-rainville
requested changes
Mar 6, 2020
Cheddam
force-pushed
the
pulls/master/url-alias
branch
from
2278c36 to
3ca18a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Browsers already have a
URLkey on theirwindowobject, so this clashes with the expose-loader entry and makes it unusable.Pairs with an adjustment to the expose-loader entry in
silverstripe/admin: silverstripe/silverstripe-admin#1019