Review (and fix) SS3 styling

[brynwhyman]

Thoughts on what may need fixing (but review yourself)

• The front end could do with a couple of tweaks to styes inherited from admin
• Sudo mode might need some attention

PRs

MFA

• FIX Ensure buttons spacing and restore the confirmation tick for SS3 #304
• Add missing bootstrap dependency #303

WebAuthn

• FIX Convert actions toolbar to be consistent with mfa/totp silverstripe-webauthn-authenticator#52

login-forms

• Backport FIX Introduce more css vars for more specific styling silverstripe-login-forms#36
• NEW Convert login-forms to base off of bootstrap instead of framework/admin styles silverstripe-login-forms#35

[newleeland]

Not super keen to do a full design review of the SS3 MFA, But I did notice some obvious visual bugs, like the need for padding on the main action buttons.

Would it be best to get to sit down together for 30mins and go over it, or use a local server?

[ScopeyNZ]

Hi @newleeland. I don't think we expected much (any) input from PUX here. Just make sure it doesn't look completely awful. There are some parts of the admin interface that inherited styling in SS4 that don't in SS3 and look a bit weird.

[brynwhyman]

I think a sit down with PUX is worthwhile before marking this issue as done. Around 60% of sites on our platform are running SS3. It would be good to ensure this version receives a similar level of design review before we mark this work as complete.

cc @clarkepaul

[ScopeyNZ]

I think I've covered most bases now and it looks "good enough". PRs listed in the OP.

There's this issue:

silverstripe/silverstripe-security-extensions#15

Once that's fixed the invalid field styling might need a pass.

[ScopeyNZ]

Backported fixes from 4.0 so closing this