Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sudo mode password validation errors do not show in SS 3.x or 4.4 #15

Closed
robbieaverill opened this issue Aug 2, 2019 · 3 comments
Closed

Sudo mode password validation errors do not show in SS 3.x or 4.4 #15

robbieaverill opened this issue Aug 2, 2019 · 3 comments
Labels
affects/v4 complexity/low impact/high type/bug Something isn't working type/UX
Milestone
Sprint 64

Comments

@robbieaverill
Copy link
Contributor

See #14 (review)
@ScopeyNZ ScopeyNZ mentioned this issue Aug 2, 2019
Closed
5 tasks
@robbieaverill
Copy link
Contributor Author

Still an issue

@robbieaverill robbieaverill mentioned this issue Aug 23, 2019
Open
@robbieaverill robbieaverill self-assigned this Aug 23, 2019
@robbieaverill
Copy link
Contributor Author

robbieaverill commented Aug 23, 2019 •
edited
Loading

The problem is that #sudoModePassword (the text input) doesn't get is-invalid applied to its class list when it fails validation. This could be a difference in Bootstrap versions, maybe. This should be controlled by Reactstrap based on whether you pass valid:true|false as a component prop. We've seen problems with how it handles this versus invalid before, so maybe needs to be tinkered with a bit more.

I've tried to replicate this via the Reactstrap starter project they suggest you use to show your bugs when you report them, but wasn't able to with React 16, Bootstrap 4.3.

@robbieaverill robbieaverill removed their assignment Aug 25, 2019
@emteknetnz emteknetnz self-assigned this Jul 19, 2020
This was referenced Jul 20, 2020
Merged
Merged
@emteknetnz
Copy link
Member

emteknetnz commented Jul 20, 2020 •
edited
Loading

Fixed in:
SS4 #34
SS3 #35

@emteknetnz emteknetnz removed their assignment Jul 20, 2020
@emteknetnz emteknetnz added this to the Sprint 63 milestone Jul 21, 2020
@dnsl48 dnsl48 modified the milestones: Sprint 63, Sprint 64 Jul 21, 2020
@emteknetnz emteknetnz removed their assignment Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects/v4 complexity/low impact/high type/bug Something isn't working type/UX
Projects
None yet
Milestone
Sprint 64
Development

No branches or pull requests
3 participants
@emteknetnz @robbieaverill @dnsl48