Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX Set the invalid prop when errorMessage - SS3 #35

Merged

Conversation

emteknetnz
Copy link
Member

Fixes #15

SS4 PR #34

Before
image

After
image

@robbieaverill
Copy link
Contributor

Does this PR need the same Bootstrap compatibility? From memory it doesn't

@emteknetnz emteknetnz force-pushed the pulls/3.0/validation-props branch from 5a5adf3 to 0235ec9 Compare July 22, 2020 22:07
@emteknetnz
Copy link
Member Author

@robbieaverill I've updated this PR to use { valid: false, invalid: true } like the SS4 version. I've tested locally and it still works correctly in 3.7.4

Note: one of the travis checks in stuck in pending. The travis builds are actually green.

@robbieaverill robbieaverill merged commit ce4f247 into silverstripe:3.0 Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants