FIX Improve styling of sudo mode prompt in SS3 #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robbieaverill
approved these changes
Aug 1, 2019
robbieaverill
suggested changes
Aug 1, 2019
|
Hmmmn. This isn't working on 4.4 for me either. This might be related to the bootstrap upgrade though... I'll play around with 4.3 too. Can we move this to a separate issue? It'll probably end up with a PR to the |
robbieaverill
approved these changes
Aug 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar level of hackiness to
silverstripe/mfa. The simplist solution is just to incude the relevant bootstrap styling into the scss for the component. I needed to add a container in order to get the style affecting children correctly.