Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX Convert actions toolbar to be consistent with mfa/totp #52

Conversation

ScopeyNZ
Copy link
Contributor

@ScopeyNZ ScopeyNZ commented Aug 2, 2019

There's some styling that's added by the base MFA module that applies to actions with the classes that I've added in this PR. I had to keep the existing classes too as they define some grid specific attributes.

Copy link
Contributor

@robbieaverill robbieaverill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build broke, but changes look good

@ScopeyNZ ScopeyNZ force-pushed the pulls/4.0/action-consistency branch from dc199a7 to f3bbe69 Compare August 2, 2019 03:35
@ScopeyNZ
Copy link
Contributor Author

ScopeyNZ commented Aug 2, 2019

Heh - valid failure in some respects. Also yarn build was missing yarn test as a step so I added that in.

@robbieaverill robbieaverill merged commit e539320 into silverstripe:4.0 Aug 2, 2019
@robbieaverill robbieaverill deleted the pulls/4.0/action-consistency branch August 2, 2019 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants