Skip to content

Add check to sensor #337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 7, 2023
Merged

Add check to sensor #337

merged 2 commits into from
Nov 7, 2023

Conversation

runger1101001
Copy link
Member

  • Check that returned angles from subclasses getSensorAngle() calls are non-negative

This allows a sensor driver to not return an angle in the case of failed CRC checks, etc by returning a negative value
Part of improvement #334

  • Remove warnings in Commander about using Strings as char* by changing type to const char* and casting to char* elsewhere

@runger1101001 runger1101001 merged commit 639ccab into simplefoc:dev Nov 7, 2023
@runger1101001 runger1101001 added this to the 2.3.2_Release milestone Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.3.2_Release
Development

Successfully merging this pull request may close these issues.
1 participant
@runger1101001