improvement(workflow-execution): perf improvements to passing workflow state + decrypted env vars

[icecrasher321]

Summary

• Only load workflow state once and pass it through
• Only decrypt env vars in parallel once and pass them through

Type of Change

• Other: Performance

Testing

Tested manually running

Checklist

• Code follows project style guidelines
• Self-reviewed my changes
• Tests added/updated and passing
• No new warnings introduced
• I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Preview	Comments	Updated (UTC)
docs	Skipped			Nov 26, 2025 4:07am

[greptile-apps]

Greptile Overview

Greptile Summary

Optimized workflow execution performance by eliminating redundant database calls and parallelizing environment variable decryption.

Key improvements:

• Caches workflow state once in route.ts and passes it through to executeWorkflowCore, preventing duplicate DB queries
• Parallelizes environment variable decryption in utils.ts using Promise.all instead of sequential for loop
• Removes redundant decryption loop in execution-core.ts by using pre-decrypted values from getPersonalAndWorkspaceEnv
• Converts nested async reduce operations to synchronous reduces since decryption is now done upfront

The changes maintain identical functionality while reducing execution time through better resource utilization.

Confidence Score: 5/5

• This PR is safe to merge with minimal risk
• Score reflects well-designed performance optimizations that maintain functional equivalence: workflow state caching eliminates redundant DB calls without changing behavior, parallel decryption is a straightforward performance win with proper error handling preserved, and the conversion from async to sync reduces is safe since all async work (decryption) is now done upfront
• No files require special attention

Important Files Changed

File Analysis

Filename	Score	Overview
apps/sim/app/api/workflows/[id]/execute/route.ts	5/5	Caches workflow state once to avoid duplicate DB calls in executeWorkflowCore and streaming paths
apps/sim/lib/environment/utils.ts	5/5	Parallelizes decryption of environment variables using Promise.all for better performance
apps/sim/lib/workflows/executor/execution-core.ts	5/5	Uses pre-decrypted env vars, converts async reduces to sync, removes redundant decryption loop

Sequence Diagram

sequenceDiagram
    participant Client
    participant Route as execute/route.ts
    participant Utils as environment/utils.ts
    participant Core as execution-core.ts
    participant DB as Database

    Client->>Route: POST /api/workflows/[id]/execute
    Route->>DB: Load workflow state (once)
    DB-->>Route: Workflow data (blocks, edges, loops, parallels)
    Note over Route: Cache workflow data in<br/>cachedWorkflowData
    
    Route->>Route: Create effectiveWorkflowStateOverride<br/>(user override OR cached data)
    
    alt Non-SSE Execution
        Route->>Core: executeWorkflowCore(workflowStateOverride)
        Core->>Utils: getPersonalAndWorkspaceEnv()
        Utils->>DB: Fetch encrypted env vars
        DB-->>Utils: Encrypted variables
        Note over Utils: Decrypt ALL vars in parallel<br/>using Promise.all
        Utils-->>Core: {encrypted, decrypted} env vars
        Note over Core: Use cached workflow state<br/>(no DB reload)
        Note over Core: Use pre-decrypted vars<br/>(no redundant decryption)
        Core->>Core: Process block states (sync reduce)
        Core-->>Route: Execution result
        Route-->>Client: JSON response
    else SSE Execution
        Route->>Route: resolveOutputIds(cachedWorkflowData.blocks)
        Note over Route: Use cached data<br/>(no DB reload)
        Route->>Core: executeWorkflowCore(workflowStateOverride)
        Core->>Utils: getPersonalAndWorkspaceEnv()
        Utils->>DB: Fetch encrypted env vars
        DB-->>Utils: Encrypted variables
        Note over Utils: Decrypt ALL vars in parallel<br/>using Promise.all
        Utils-->>Core: {encrypted, decrypted} env vars
        Note over Core: Use cached workflow state<br/>(no DB reload)
        Note over Core: Use pre-decrypted vars<br/>(no redundant decryption)
        Core->>Core: Process block states (sync reduce)
        Core-->>Route: Execution result (streaming)
        Route-->>Client: SSE stream
    end

Loading

[greptile-apps]

_{3 files reviewed, no comments}

_{Edit Code Review Agent Settings | Greptile}