fix(custom-tools): add composite index on custom tool names & workspace id

[waleedlatif1]

Summary

• add composite index on custom tool names & workspace id

Type of Change

• Bug fix

Testing

Tested manually

Checklist

• Code follows project style guidelines
• Self-reviewed my changes
• Tests added/updated and passing
• No new warnings introduced
• I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Preview	Comments	Updated (UTC)
docs	Skipped			Nov 28, 2025 11:24pm

[greptile-apps]

Greptile Overview

Greptile Summary

This PR adds a composite unique index on workspace_id and title for custom tools, allowing different workspaces to have tools with the same title. The migration converts existing function-name-based IDs to UUIDs and simplifies the upsert logic.

Critical Issue Found:

• The migration changes existing tool IDs from function names (e.g., get_weather) to UUIDs, but the application code still tries to update tools using the old function-name IDs
• When an update attempt fails to find a tool by its old ID, the code falls through to the duplicate title check and throws an error, blocking legitimate updates to existing tools
• This will break tool updates for all workspace-scoped tools that existed before the migration

Major Changes:

• Removed function name validation and enforcement (tools no longer use function name as ID)
• Changed from checking duplicate function names to checking duplicate titles per workspace
• New tools now use nanoid() instead of function name as the primary key
• Removed extensive comments explaining the logic

Recommendation: The ID migration strategy needs revision to handle the transition period where old IDs may still be in use, or ensure all references to old IDs are updated before deploying this change.

Confidence Score: 1/5

• This PR contains a critical bug that will break updates to existing custom tools after migration
• The migration changes tool IDs from function names to UUIDs, but the application code continues to use old function-name IDs when attempting updates. This causes legitimate updates to fail with "duplicate title" errors. The issue affects all workspace-scoped custom tools created before this migration runs. While the goal (allowing same title across workspaces) is valid, the implementation has a critical flaw in the migration strategy.
• Pay close attention to packages/db/migrations/0113_calm_tiger_shark.sql and apps/sim/lib/custom-tools/operations.ts - these contain the critical bug that breaks tool updates

Important Files Changed

File Analysis

Filename	Score	Overview
packages/db/migrations/0113_calm_tiger_shark.sql	1/5	Migration converts function-name IDs to UUIDs, breaking existing tool updates due to ID mismatch
apps/sim/lib/custom-tools/operations.ts	2/5	Simplified upsert logic but duplicate title check now blocks updates of migrated tools
apps/sim/lib/workflows/custom-tools-persistence.ts	4/5	Passes toolId instead of function name, minor cleanup, mostly safe changes

Sequence Diagram

sequenceDiagram
    participant WF as Workflow State
    participant CPT as custom-tools-persistence.ts
    participant OPS as operations.ts
    participant DB as Database (custom_tools)
    
    Note over DB: Migration 0113 runs:<br/>function-name IDs → UUIDs
    
    WF->>CPT: Save workflow with custom tools
    CPT->>CPT: extractCustomToolsFromWorkflowState()
    CPT->>CPT: Filter tools with function.name
    
    CPT->>OPS: upsertCustomTools({tools, workspaceId})
    Note over OPS: tool.id = toolId (may be old function name)
    
    alt tool.id exists
        OPS->>DB: SELECT by id + workspaceId
        alt Found (UUID matches)
            OPS->>DB: UPDATE tool
            DB-->>OPS: Success
        else Not found (old function name)
            OPS->>DB: SELECT legacy tool (no workspaceId)
            alt Legacy found
                OPS->>DB: UPDATE legacy tool
                DB-->>OPS: Success
            else Not found anywhere
                OPS->>DB: SELECT by workspaceId + title
                alt Duplicate title exists
                    OPS-->>CPT: Error: duplicate title
                    Note over OPS,CPT: ⚠️ BREAKS HERE<br/>Can't update migrated tool!
                else No duplicate
                    OPS->>DB: INSERT new tool (nanoid)
                    DB-->>OPS: Success
                end
            end
        end
    else No tool.id
        OPS->>DB: SELECT by workspaceId + title
        alt Duplicate exists
            OPS-->>CPT: Error: duplicate title
        else No duplicate
            OPS->>DB: INSERT new tool (nanoid)
            DB-->>OPS: Success
        end
    end
    
    OPS->>DB: SELECT all workspace tools
    DB-->>OPS: Return tools
    OPS-->>CPT: Return result
    CPT-->>WF: Persistence complete

Loading

[greptile-apps]

_{6 files reviewed, 2 comments}

_{Edit Code Review Agent Settings | Greptile}