fix(polling): mark webhook failed on webhook trigger errors

[waleedlatif1]

Summary

• mark webhook failed on webhook trigger errors, wasn't tracking 403 and 500's in failedCount

Type of Change

• Bug fix

Testing

Tested manually

Checklist

• Code follows project style guidelines
• Self-reviewed my changes
• Tests added/updated and passing
• No new warnings introduced
• I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Preview	Comments	Updated (UTC)
docs	Skipped			Dec 1, 2025 4:07pm

[greptile-apps]

Greptile Overview

Greptile Summary

This PR fixes a bug where webhook trigger errors (403s and 500s) weren't being tracked in the failedCount metric for Gmail and Outlook polling webhooks.

Changes Made:

• Modified processEmails and processOutlookEmails functions to return both processedCount and failedCount instead of just a count
• Added failedCount tracking that increments when individual email processing fails
• Updated webhook status logic: webhooks are now marked as failed only when ALL emails fail to process (processedCount === 0 && failedCount > 0)
• Improved logging to show both successful and failed email counts

Impact:
The fix ensures that webhooks failing to trigger due to HTTP errors (403, 500) will now properly accumulate in failedCount, allowing the system to auto-disable webhooks after 10 consecutive failures as designed.

Confidence Score: 5/5

• This PR is safe to merge with minimal risk
• The changes are straightforward, well-tested manually, and follow existing patterns. The logic correctly tracks failed email processing and only marks webhooks as failed when ALL emails fail, preventing false positives. The implementation is consistent across both Gmail and Outlook services.
• No files require special attention

Important Files Changed

File Analysis

Filename	Score	Overview
apps/sim/lib/webhooks/gmail-polling-service.ts	5/5	Added failedCount tracking in processEmails function and conditional webhook status marking based on whether all emails failed vs some succeeded
apps/sim/lib/webhooks/outlook-polling-service.ts	5/5	Added failedCount tracking in processOutlookEmails function and conditional webhook status marking based on whether all emails failed vs some succeeded

Sequence Diagram

sequenceDiagram
    participant Poller as Polling Service
    participant Process as processEmails()
    participant Webhook as Webhook API
    participant DB as Database
    
    Poller->>Process: Process emails array
    
    loop For each email
        Process->>Webhook: POST /api/webhooks/trigger/{path}
        alt Webhook Success (200)
            Webhook-->>Process: Success response
            Process->>Process: processedCount++
        else Webhook Error (403/500)
            Webhook-->>Process: Error response
            Process->>Process: failedCount++
        end
    end
    
    Process-->>Poller: Return {processedCount, failedCount}
    
    alt All emails failed (processedCount=0, failedCount>0)
        Poller->>DB: markWebhookFailed(webhookId)
        DB->>DB: failedCount += 1
        DB->>DB: Check if failedCount >= 10
        alt Reached max failures
            DB->>DB: Set isActive = false
        end
    else At least some succeeded
        Poller->>DB: markWebhookSuccess(webhookId)
        DB->>DB: Reset failedCount = 0
    end

Loading

[greptile-apps]

_{2 files reviewed, no comments}

_{Edit Code Review Agent Settings | Greptile}