fix(createWorkflow): cleanup create workflow to prevent re-renders by icecrasher321 · Pull Request #607 · simstudioai/sim

icecrasher321 · 2025-07-02T20:14:14Z

Description

No more client side id generation for new workflows, update scheduling deps to be correct, add loading state during creation of workflows to prevent race condition generating spams of the add button.

Changed naming to be more fun. Added way more colors.

Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Test creating workflows, creating workspaces and switching between things.

Checklist:

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have added tests that prove my fix is effective or that my feature works
All tests pass locally and in CI (bun run test)
My changes generate no new warnings
Any dependent changes have been merged and published in downstream modules
I have updated version numbers as needed (if needed)
I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Security Considerations:

My changes do not introduce any new security vulnerabilities
I have considered the security implications of my changes

vercel · 2025-07-02T20:14:20Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
sim	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 2, 2025 8:22pm

1 Skipped Deployment

Name	Status	Preview	Comments	Updated (UTC)
docs	⬜️ Skipped (Inspect)			Jul 2, 2025 8:22pm

greptile-apps

PR Summary

Significant refactoring to prevent race conditions and improve workflow creation UX, moving ID generation server-side and adding loading states.

Improved WorkflowBlock to use URL params instead of global state, preventing race conditions during rapid workflow switches
Added isCreatingWorkflow loading state in Sidebar and CreateMenu to prevent duplicate workflow creation from rapid clicks
Changed workflow naming from sequential (e.g. 'Workflow 1') to descriptive adjective-noun pairs (e.g. 'blazing-phoenix')
Expanded color palette from 7 to 90 colors with random selection instead of sequential rotation
Updated ScheduleConfig component to optimize re-renders by improving dependency arrays and cleanup functions

_{7 files reviewed, 3 comments}
_{Edit PR Review Bot Settings | Greptile}

.../sim/app/workspace/[workspaceId]/w/components/sidebar/components/create-menu/create-menu.tsx

apps/sim/stores/workflows/registry/utils.ts

greptile-apps · 2025-07-02T20:14:56Z

apps/sim/stores/workflows/registry/utils.ts

+  '#059669', // Green Teal
+  '#16A34A', // Forest Green
+  '#22C55E', // Lime Green
+  '#84CC16', // Yellow Green
+  '#65A30D', // Olive Green
+  '#15803D', // Dark Green

-  // Get the newest workflow (first in sorted array)
-  const newestWorkflow = sortedWorkflows[0]
+  // Additional vibrant teals/cyans
+  '#06B6D4', // Cyan
+  '#0891B2', // Dark Cyan
+  '#0E7490', // Teal Blue
+  '#14B8A6', // Turquoise
+  '#0D9488', // Dark Teal
+  '#047857', // Sea Green
+  '#059669', // Mint Green


logic: Duplicate color definition: '#059669' appears twice (Green Teal and Mint Green). Should be removed to prevent confusion in color selection.

delve-auditor · 2025-07-02T20:15:42Z

✅ No security or compliance issues detected. Reviewed everything up to f5c53e9.

Security Overview

🔎 Scanned files: 7 changed file(s)

Detected Code Changes

Change Type	Relevant files
Enhancement	► route.ts Update initial workflow naming convention ► schedule-config.tsx Optimize schedule checking logic ► workflow-block.tsx Improve workflow block handling ► create-menu.tsx Add workflow creation status indicator ► store.ts Refactor workflow creation process ► utils.ts Enhance workflow name and color generation

Reply to this PR with @delve-auditor followed by a description of what change you want and we'll auto-submit a change to this PR to implement it.

Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>

icecrasher321 · 2025-07-02T20:29:51Z

...owId]/components/workflow-block/components/sub-block/components/schedule/schedule-config.tsx

 export function ScheduleConfig({
  blockId,
-  subBlockId,
+  subBlockId: _subBlockId,


these are unused -- but I wasn't sure why they were ever passed in and didn't want to remove them rn. So using underscore to indicate unused and not get a linter unused warning.

* feat(function): added more granular error logs for function execution for easier debugging (#593) * added more granular error logs for function execution * added tests * fixed syntax error reporting * feat(models): added temp controls for gpt-4.1 family of models (#594) * improvement(knowledge-upload): create and upload document to KB (#579) * improvement: added knowledge upload * improvement: added greptile comments (#579) * improvement: changed to text to doc (#579) * improvement: removed comment (#579) * added input validation, tested persistence of KB selector * update docs --------- Co-authored-by: Adam Gough <adamgough@Mac.attlocal.net> Co-authored-by: Waleed Latif <walif6@gmail.com> * fix(remove workflow.state usage): no more usage of deprecated state column in any routes (#586) * fix(remove workflow.state usage): no more usage of deprecated state col in routes * fix lint * fix chat route to only use deployed state * fix lint * better typing * remove useless logs * fix lint * restore workflow handler file * removed all other usages of deprecated 'state' column from workflows table, updated tests --------- Co-authored-by: Vikhyath Mondreti <vikhyathmondreti@Vikhyaths-MacBook-Air.local> Co-authored-by: Waleed Latif <walif6@gmail.com> * fix(doc-selector-kb): enable doc selector when kb is selected (#596) Co-authored-by: Vikhyath Mondreti <vikhyathmondreti@vikhyaths-air.lan> * fix(unload): remove beforeunload warning since we communicate via wss (#597) * fix(executor): fix dependency resolution, allow blocks with multiple inputs to execute (#598) * feat(billing): added migrations for usage-based billing (#601) * feat(billing): added migrations for usage-based billing * lint * lint * feat(logging): add new schemas + types for new logging system (#599) * feat(logging): add new schemas + types for logging * fix lint * update migration * fix lint * Remove migration 48 to avoid conflict with staging * fixed merge conflict * fix lint --------- Co-authored-by: Vikhyath Mondreti <vikhyathmondreti@Vikhyaths-Air.attlocal.net> * fix(createWorkflow): cleanup create workflow to prevent re-renders (#607) * fix(createWorkflow): no more client side id, duplicate schedules calls * fix lint * more cleanup * fix lint * fix spamming of create button causing issues * fix lint * add more colors + default workflow name changed * Update apps/sim/stores/workflows/registry/utils.ts Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> --------- Co-authored-by: Vikhyath Mondreti <vikhyathmondreti@Vikhyaths-Air.attlocal.net> Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> * fix(telegram): added markdown text rendering (#611) * fix: added proper markdown * fix: reverted route.ts file --------- Co-authored-by: Adam Gough <adamgough@Adams-MacBook-Pro.local> * fix(kb-upload): fix and consolidate KB file uploads logic (#610) * fix(kb-upload): fix and consolidate logic * fix lint * consolidated presigned routes, fixed temp id kb store issue, added nav to next/prev chunk on edit chunk modal * fix ci test --------- Co-authored-by: Vikhyath Mondreti <vikhyathmondreti@vikhyaths-air.lan> Co-authored-by: Waleed Latif <walif6@gmail.com> --------- Co-authored-by: Waleed Latif <walif6@gmail.com> Co-authored-by: Adam Gough <77861281+aadamgough@users.noreply.github.com> Co-authored-by: Adam Gough <adamgough@Mac.attlocal.net> Co-authored-by: Vikhyath Mondreti <vikhyathmondreti@Vikhyaths-MacBook-Air.local> Co-authored-by: Vikhyath Mondreti <vikhyathmondreti@vikhyaths-air.lan> Co-authored-by: Vikhyath Mondreti <vikhyathmondreti@Vikhyaths-Air.attlocal.net> Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> Co-authored-by: Adam Gough <adamgough@Adams-MacBook-Pro.local>

* feat(function): added more granular error logs for function execution for easier debugging (simstudioai#593) * added more granular error logs for function execution * added tests * fixed syntax error reporting * feat(models): added temp controls for gpt-4.1 family of models (simstudioai#594) * improvement(knowledge-upload): create and upload document to KB (simstudioai#579) * improvement: added knowledge upload * improvement: added greptile comments (simstudioai#579) * improvement: changed to text to doc (simstudioai#579) * improvement: removed comment (simstudioai#579) * added input validation, tested persistence of KB selector * update docs --------- Co-authored-by: Adam Gough <adamgough@Mac.attlocal.net> Co-authored-by: Waleed Latif <walif6@gmail.com> * fix(remove workflow.state usage): no more usage of deprecated state column in any routes (simstudioai#586) * fix(remove workflow.state usage): no more usage of deprecated state col in routes * fix lint * fix chat route to only use deployed state * fix lint * better typing * remove useless logs * fix lint * restore workflow handler file * removed all other usages of deprecated 'state' column from workflows table, updated tests --------- Co-authored-by: Vikhyath Mondreti <vikhyathmondreti@Vikhyaths-MacBook-Air.local> Co-authored-by: Waleed Latif <walif6@gmail.com> * fix(doc-selector-kb): enable doc selector when kb is selected (simstudioai#596) Co-authored-by: Vikhyath Mondreti <vikhyathmondreti@vikhyaths-air.lan> * fix(unload): remove beforeunload warning since we communicate via wss (simstudioai#597) * fix(executor): fix dependency resolution, allow blocks with multiple inputs to execute (simstudioai#598) * feat(billing): added migrations for usage-based billing (simstudioai#601) * feat(billing): added migrations for usage-based billing * lint * lint * feat(logging): add new schemas + types for new logging system (simstudioai#599) * feat(logging): add new schemas + types for logging * fix lint * update migration * fix lint * Remove migration 48 to avoid conflict with staging * fixed merge conflict * fix lint --------- Co-authored-by: Vikhyath Mondreti <vikhyathmondreti@Vikhyaths-Air.attlocal.net> * fix(createWorkflow): cleanup create workflow to prevent re-renders (simstudioai#607) * fix(createWorkflow): no more client side id, duplicate schedules calls * fix lint * more cleanup * fix lint * fix spamming of create button causing issues * fix lint * add more colors + default workflow name changed * Update apps/sim/stores/workflows/registry/utils.ts Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> --------- Co-authored-by: Vikhyath Mondreti <vikhyathmondreti@Vikhyaths-Air.attlocal.net> Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> * fix(telegram): added markdown text rendering (simstudioai#611) * fix: added proper markdown * fix: reverted route.ts file --------- Co-authored-by: Adam Gough <adamgough@Adams-MacBook-Pro.local> * fix(kb-upload): fix and consolidate KB file uploads logic (simstudioai#610) * fix(kb-upload): fix and consolidate logic * fix lint * consolidated presigned routes, fixed temp id kb store issue, added nav to next/prev chunk on edit chunk modal * fix ci test --------- Co-authored-by: Vikhyath Mondreti <vikhyathmondreti@vikhyaths-air.lan> Co-authored-by: Waleed Latif <walif6@gmail.com> --------- Co-authored-by: Waleed Latif <walif6@gmail.com> Co-authored-by: Adam Gough <77861281+aadamgough@users.noreply.github.com> Co-authored-by: Adam Gough <adamgough@Mac.attlocal.net> Co-authored-by: Vikhyath Mondreti <vikhyathmondreti@Vikhyaths-MacBook-Air.local> Co-authored-by: Vikhyath Mondreti <vikhyathmondreti@vikhyaths-air.lan> Co-authored-by: Vikhyath Mondreti <vikhyathmondreti@Vikhyaths-Air.attlocal.net> Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> Co-authored-by: Adam Gough <adamgough@Adams-MacBook-Pro.local>

Vikhyath Mondreti added 7 commits July 2, 2025 12:06

fix(createWorkflow): no more client side id, duplicate schedules calls

a4fa6ca

fix lint

eeb677d

more cleanup

ea5dfa1

fix lint

8ce5b51

fix spamming of create button causing issues

3b1e822

fix lint

248d0f2

add more colors + default workflow name changed

48f9d2b

vercel bot deployed to Preview – sim July 2, 2025 20:14 View deployment

greptile-apps bot reviewed Jul 2, 2025

View reviewed changes

Update apps/sim/stores/workflows/registry/utils.ts

f5c53e9

Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>

vercel bot temporarily deployed to Preview – docs July 2, 2025 20:16 Inactive

vercel bot deployed to Preview – sim July 2, 2025 20:22 View deployment

icecrasher321 merged commit 2d5ddf6 into staging Jul 2, 2025
6 checks passed

icecrasher321 commented Jul 2, 2025

View reviewed changes

waleedlatif1 deleted the fix/re-renders-create-workflow branch July 8, 2025 23:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(createWorkflow): cleanup create workflow to prevent re-renders#607

fix(createWorkflow): cleanup create workflow to prevent re-renders#607
icecrasher321 merged 8 commits intostagingfrom
fix/re-renders-create-workflow

icecrasher321 commented Jul 2, 2025 •

edited

Loading

Uh oh!

vercel bot commented Jul 2, 2025 •

edited

Loading

Uh oh!

greptile-apps bot left a comment

Uh oh!

Uh oh!

Uh oh!

greptile-apps bot Jul 2, 2025

Uh oh!

delve-auditor bot commented Jul 2, 2025 •

edited

Loading

Uh oh!

Uh oh!

icecrasher321 Jul 2, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

icecrasher321 commented Jul 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Type of change

How Has This Been Tested?

Checklist:

Security Considerations:

Uh oh!

vercel bot commented Jul 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

PR Summary

Uh oh!

Uh oh!

Uh oh!

greptile-apps bot Jul 2, 2025

Choose a reason for hiding this comment

Uh oh!

delve-auditor bot commented Jul 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

icecrasher321 Jul 2, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

icecrasher321 commented Jul 2, 2025 •

edited

Loading

vercel bot commented Jul 2, 2025 •

edited

Loading

delve-auditor bot commented Jul 2, 2025 •

edited

Loading