fix(kb-upload): fix and consolidate KB file uploads logic #610

icecrasher321 · 2025-07-03T18:35:02Z

Description

base.tsx was not using presigned URL endpoint. Also the KB configs were not being used by regular upload endpoint. So separate endpoint for KB uploads now. Accessible client function via a shared hook so there's no difference in upload location.

Type of change

Bug fix (non-breaking change which fixes an issue)
Code refactoring (no functional changes)

How Has This Been Tested?

PLEASE TEST WITH S3. I tested with Azure Blob KB config.

Screen.Recording.2025-07-03.at.11.28.23.AM.mov

Checklist:

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have added tests that prove my fix is effective or that my feature works
All tests pass locally and in CI (bun run test)
My changes generate no new warnings
Any dependent changes have been merged and published in downstream modules
I have updated version numbers as needed (if needed)
I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Security Considerations:

My changes do not introduce any new security vulnerabilities
I have considered the security implications of my changes

vercel · 2025-07-03T18:35:07Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
sim	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 3, 2025 7:52pm

1 Skipped Deployment

Name	Status	Preview	Comments	Updated (UTC)
docs	⬜️ Skipped (Inspect)			Jul 3, 2025 7:52pm

greptile-apps

PR Summary

Consolidates and fixes knowledge base file upload functionality by implementing a new centralized approach with dedicated configurations and endpoints.

Added new useKnowledgeUpload hook in apps/sim/app/workspace/[workspaceId]/knowledge/hooks/use-knowledge-upload.ts to centralize upload logic
Created KB-specific presigned URL endpoint in apps/sim/app/api/knowledge/presigned/route.ts using dedicated storage configs
Fixed base.tsx to properly use presigned URL endpoints for KB file uploads
Added KB-specific download handling in apps/sim/app/api/files/serve/[...path]/route.ts with support for both Azure Blob and S3
Improved separation of concerns by moving file processing logic from components to the hook

_{5 files reviewed, 9 comments}
_{Edit PR Review Bot Settings | Greptile}

apps/sim/app/api/files/serve/[...path]/route.ts

apps/sim/app/workspace/[workspaceId]/knowledge/hooks/use-knowledge-upload.ts

apps/sim/app/workspace/[workspaceId]/knowledge/[id]/base.tsx

apps/sim/app/api/knowledge/presigned/route.ts

apps/sim/app/workspace/[workspaceId]/knowledge/hooks/use-knowledge-upload.ts

apps/sim/app/api/knowledge/presigned/route.ts

delve-auditor · 2025-07-03T18:36:10Z

✅ No security or compliance issues detected. Reviewed everything up to f7ecf47.

Security Overview

🔎 Scanned files: 12 changed file(s)

Detected Code Changes

Change Type	Relevant files
Bug Fix	► utils.ts Add test configuration for storage providers ► route.test.ts Update file upload endpoint tests ► route.ts Improve error handling and validation for file uploads ► route.ts Implement knowledge base file handling ► edit-chunk-modal.tsx Add navigation controls for chunks ► base.tsx Refactor file upload logic ► use-knowledge-upload.ts Add new hook for file upload management ► s3-client.test.ts Update client initialization tests ► store.ts Improve document merging logic

Reply to this PR with @delve-auditor followed by a description of what change you want and we'll auto-submit a change to this PR to implement it.

…v to next/prev chunk on edit chunk modal

* feat(function): added more granular error logs for function execution for easier debugging (#593) * added more granular error logs for function execution * added tests * fixed syntax error reporting * feat(models): added temp controls for gpt-4.1 family of models (#594) * improvement(knowledge-upload): create and upload document to KB (#579) * improvement: added knowledge upload * improvement: added greptile comments (#579) * improvement: changed to text to doc (#579) * improvement: removed comment (#579) * added input validation, tested persistence of KB selector * update docs --------- Co-authored-by: Adam Gough <adamgough@Mac.attlocal.net> Co-authored-by: Waleed Latif <walif6@gmail.com> * fix(remove workflow.state usage): no more usage of deprecated state column in any routes (#586) * fix(remove workflow.state usage): no more usage of deprecated state col in routes * fix lint * fix chat route to only use deployed state * fix lint * better typing * remove useless logs * fix lint * restore workflow handler file * removed all other usages of deprecated 'state' column from workflows table, updated tests --------- Co-authored-by: Vikhyath Mondreti <vikhyathmondreti@Vikhyaths-MacBook-Air.local> Co-authored-by: Waleed Latif <walif6@gmail.com> * fix(doc-selector-kb): enable doc selector when kb is selected (#596) Co-authored-by: Vikhyath Mondreti <vikhyathmondreti@vikhyaths-air.lan> * fix(unload): remove beforeunload warning since we communicate via wss (#597) * fix(executor): fix dependency resolution, allow blocks with multiple inputs to execute (#598) * feat(billing): added migrations for usage-based billing (#601) * feat(billing): added migrations for usage-based billing * lint * lint * feat(logging): add new schemas + types for new logging system (#599) * feat(logging): add new schemas + types for logging * fix lint * update migration * fix lint * Remove migration 48 to avoid conflict with staging * fixed merge conflict * fix lint --------- Co-authored-by: Vikhyath Mondreti <vikhyathmondreti@Vikhyaths-Air.attlocal.net> * fix(createWorkflow): cleanup create workflow to prevent re-renders (#607) * fix(createWorkflow): no more client side id, duplicate schedules calls * fix lint * more cleanup * fix lint * fix spamming of create button causing issues * fix lint * add more colors + default workflow name changed * Update apps/sim/stores/workflows/registry/utils.ts Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> --------- Co-authored-by: Vikhyath Mondreti <vikhyathmondreti@Vikhyaths-Air.attlocal.net> Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> * fix(telegram): added markdown text rendering (#611) * fix: added proper markdown * fix: reverted route.ts file --------- Co-authored-by: Adam Gough <adamgough@Adams-MacBook-Pro.local> * fix(kb-upload): fix and consolidate KB file uploads logic (#610) * fix(kb-upload): fix and consolidate logic * fix lint * consolidated presigned routes, fixed temp id kb store issue, added nav to next/prev chunk on edit chunk modal * fix ci test --------- Co-authored-by: Vikhyath Mondreti <vikhyathmondreti@vikhyaths-air.lan> Co-authored-by: Waleed Latif <walif6@gmail.com> --------- Co-authored-by: Waleed Latif <walif6@gmail.com> Co-authored-by: Adam Gough <77861281+aadamgough@users.noreply.github.com> Co-authored-by: Adam Gough <adamgough@Mac.attlocal.net> Co-authored-by: Vikhyath Mondreti <vikhyathmondreti@Vikhyaths-MacBook-Air.local> Co-authored-by: Vikhyath Mondreti <vikhyathmondreti@vikhyaths-air.lan> Co-authored-by: Vikhyath Mondreti <vikhyathmondreti@Vikhyaths-Air.attlocal.net> Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> Co-authored-by: Adam Gough <adamgough@Adams-MacBook-Pro.local>

* feat(function): added more granular error logs for function execution for easier debugging (simstudioai#593) * added more granular error logs for function execution * added tests * fixed syntax error reporting * feat(models): added temp controls for gpt-4.1 family of models (simstudioai#594) * improvement(knowledge-upload): create and upload document to KB (simstudioai#579) * improvement: added knowledge upload * improvement: added greptile comments (simstudioai#579) * improvement: changed to text to doc (simstudioai#579) * improvement: removed comment (simstudioai#579) * added input validation, tested persistence of KB selector * update docs --------- Co-authored-by: Adam Gough <adamgough@Mac.attlocal.net> Co-authored-by: Waleed Latif <walif6@gmail.com> * fix(remove workflow.state usage): no more usage of deprecated state column in any routes (simstudioai#586) * fix(remove workflow.state usage): no more usage of deprecated state col in routes * fix lint * fix chat route to only use deployed state * fix lint * better typing * remove useless logs * fix lint * restore workflow handler file * removed all other usages of deprecated 'state' column from workflows table, updated tests --------- Co-authored-by: Vikhyath Mondreti <vikhyathmondreti@Vikhyaths-MacBook-Air.local> Co-authored-by: Waleed Latif <walif6@gmail.com> * fix(doc-selector-kb): enable doc selector when kb is selected (simstudioai#596) Co-authored-by: Vikhyath Mondreti <vikhyathmondreti@vikhyaths-air.lan> * fix(unload): remove beforeunload warning since we communicate via wss (simstudioai#597) * fix(executor): fix dependency resolution, allow blocks with multiple inputs to execute (simstudioai#598) * feat(billing): added migrations for usage-based billing (simstudioai#601) * feat(billing): added migrations for usage-based billing * lint * lint * feat(logging): add new schemas + types for new logging system (simstudioai#599) * feat(logging): add new schemas + types for logging * fix lint * update migration * fix lint * Remove migration 48 to avoid conflict with staging * fixed merge conflict * fix lint --------- Co-authored-by: Vikhyath Mondreti <vikhyathmondreti@Vikhyaths-Air.attlocal.net> * fix(createWorkflow): cleanup create workflow to prevent re-renders (simstudioai#607) * fix(createWorkflow): no more client side id, duplicate schedules calls * fix lint * more cleanup * fix lint * fix spamming of create button causing issues * fix lint * add more colors + default workflow name changed * Update apps/sim/stores/workflows/registry/utils.ts Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> --------- Co-authored-by: Vikhyath Mondreti <vikhyathmondreti@Vikhyaths-Air.attlocal.net> Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> * fix(telegram): added markdown text rendering (simstudioai#611) * fix: added proper markdown * fix: reverted route.ts file --------- Co-authored-by: Adam Gough <adamgough@Adams-MacBook-Pro.local> * fix(kb-upload): fix and consolidate KB file uploads logic (simstudioai#610) * fix(kb-upload): fix and consolidate logic * fix lint * consolidated presigned routes, fixed temp id kb store issue, added nav to next/prev chunk on edit chunk modal * fix ci test --------- Co-authored-by: Vikhyath Mondreti <vikhyathmondreti@vikhyaths-air.lan> Co-authored-by: Waleed Latif <walif6@gmail.com> --------- Co-authored-by: Waleed Latif <walif6@gmail.com> Co-authored-by: Adam Gough <77861281+aadamgough@users.noreply.github.com> Co-authored-by: Adam Gough <adamgough@Mac.attlocal.net> Co-authored-by: Vikhyath Mondreti <vikhyathmondreti@Vikhyaths-MacBook-Air.local> Co-authored-by: Vikhyath Mondreti <vikhyathmondreti@vikhyaths-air.lan> Co-authored-by: Vikhyath Mondreti <vikhyathmondreti@Vikhyaths-Air.attlocal.net> Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> Co-authored-by: Adam Gough <adamgough@Adams-MacBook-Pro.local>

Vikhyath Mondreti added 2 commits July 3, 2025 11:31

fix(kb-upload): fix and consolidate logic

6102f53

fix lint

42ca79c

greptile-apps bot reviewed Jul 3, 2025

View reviewed changes

vercel bot deployed to Preview – sim July 3, 2025 18:36 View deployment

icecrasher321 assigned waleedlatif1 Jul 3, 2025

consolidated presigned routes, fixed temp id kb store issue, added na…

77f2ca6

…v to next/prev chunk on edit chunk modal

vercel bot temporarily deployed to Preview – docs July 3, 2025 19:32 Inactive

vercel bot deployed to Preview – sim July 3, 2025 19:42 View deployment

fix ci test

f7ecf47

vercel bot temporarily deployed to Preview – docs July 3, 2025 19:43 Inactive

icecrasher321 merged commit ce0a71d into staging Jul 3, 2025
5 of 6 checks passed

vercel bot deployed to Preview – sim July 3, 2025 19:52 View deployment

waleedlatif1 deleted the fix/kb-file-up branch July 4, 2025 23:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(kb-upload): fix and consolidate KB file uploads logic #610

fix(kb-upload): fix and consolidate KB file uploads logic #610

Uh oh!

icecrasher321 commented Jul 3, 2025 •

edited

Loading

Uh oh!

vercel bot commented Jul 3, 2025 •

edited

Loading

Uh oh!

greptile-apps bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

delve-auditor bot commented Jul 3, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

fix(kb-upload): fix and consolidate KB file uploads logic #610

fix(kb-upload): fix and consolidate KB file uploads logic #610

Uh oh!

Conversation

icecrasher321 commented Jul 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Type of change

How Has This Been Tested?

Checklist:

Security Considerations:

Uh oh!

vercel bot commented Jul 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

PR Summary

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

delve-auditor bot commented Jul 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

icecrasher321 commented Jul 3, 2025 •

edited

Loading

vercel bot commented Jul 3, 2025 •

edited

Loading

delve-auditor bot commented Jul 3, 2025 •

edited

Loading