fix(condition): fixed condition block dropdown#738
Merged
waleedlatif1 merged 1 commit intostagingfrom Jul 21, 2025
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
|
✅ No security or compliance issues detected. Reviewed everything up to 9dac658. Security Overview
Detected Code Changes
Reply to this PR with |
Contributor
There was a problem hiding this comment.
Greptile Summary
This PR simplifies and fixes the condition block dropdown functionality in the workflow editor. The key changes include:
- Removed the standalone
updateBlockValuefunction and integrated its logic directly into theEditorcomponent'sonValueChangehandler - Improved state management for showing/hiding tag and environment variable dropdowns
- Streamlined the data flow by handling cursor position and dropdown triggers in a single place
This change addresses a bug where condition block dropdowns weren't appearing correctly, making the feature more reliable and the code more maintainable.
Confidence score: 4/5
- This PR is safe to merge as it's a focused bug fix with minimal impact on other features
- The code changes are straightforward and improve the organization while fixing the dropdown functionality
- The
condition-input.tsxfile needs careful attention to ensure the dropdown behavior works as expected
1 file reviewed, no comments
arenadeveloper02
pushed a commit
to arenadeveloper02/p2-sim
that referenced
this pull request
Sep 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixed condition block dropdown not showing in conditions.
Type of change
How Has This Been Tested?
Tested manually.
Checklist:
bun run test)Security Considerations:
Additional Information: