-
Notifications
You must be signed in to change notification settings - Fork 3.2k
fix(create-manifest): manifest not using right tags by arch #793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| labels: ${{ steps.meta.outputs.labels }} | ||
| cache-from: type=gha,scope=build-v2 | ||
| cache-to: type=gha,mode=max,scope=build-v2 | ||
| provenance: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need these to not make manifest lists
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Greptile Summary
This PR fixes a critical bug in the Docker manifest creation process within the GitHub Actions workflow. The core issue was that the manifest creation logic wasn't properly constructing architecture-specific image names, which would cause multi-architecture manifest creation to fail or produce incomplete manifests.
The key changes include:
- Variable renaming for clarity: Changed
TAGStoMANIFEST_TAGSto better reflect the purpose of the variable - Fixed architecture-specific tag construction: The workflow now properly appends
-amd64and-arm64suffixes to the base manifest tags when looking for architecture-specific images - Added build configuration flags: Disabled provenance and SBOM generation (
provenance: false,sbom: false) to prevent potential interference with manifest creation - Improved error handling: Added detailed logging and changed from warning-based handling to hard failures when architecture images are missing
This fix is crucial for the Docker build pipeline as it ensures that multi-architecture manifests are properly created and pushed. The workflow builds images with architecture suffixes (as defined in the build matrix), but the previous manifest creation logic failed to account for this naming convention. Now users can pull images without specifying architecture-specific tags, and the manifest will properly route to the correct architecture-specific image.
Confidence score: 4/5
• This is a solid bug fix that addresses a fundamental issue in the Docker manifest creation process
• The score reflects that while the logic is sound, CI/CD changes can have subtle deployment implications that may not be immediately apparent
• The .github/workflows/build.yml file needs careful attention to ensure the matrix build strategy aligns with the new manifest creation logic
1 file reviewed, no comments
…oai#793) * fix create manifest to pick out right tags * fix
Description
Manifest not using right tags by arch -- fix by getting tags as variable.
Type of change
Checklist:
bun run test)Security Considerations: