Skip to content

Conversation

@icecrasher321
Copy link
Collaborator

Description

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • All tests pass locally and in CI (bun run test)
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • I have updated version numbers as needed (if needed)
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Security Considerations:

  • My changes do not introduce any new security vulnerabilities
  • I have considered the security implications of my changes

* fix create manifest to pick out right tags

* fix
@vercel
Copy link

vercel bot commented Jul 25, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs 🔄 Building (Inspect) Visit Preview 💬 Add feedback Jul 25, 2025 11:22pm
sim (staging) 🔄 Building (Inspect) Jul 25, 2025 11:22pm

@icecrasher321 icecrasher321 merged commit 40d3ce5 into main Jul 25, 2025
3 of 6 checks passed
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Summary

This PR fixes a critical issue in the GitHub Actions build workflow where multi-architecture Docker manifests were not being created correctly. The problem was that the manifest creation job was looking for image tags without architecture suffixes, while the actual built images included -amd64 and -arm64 suffixes.

The changes restructure the build matrix to use separate jobs for AMD64 and ARM64 architectures with native runners, improving build performance. Key technical modifications include:

  • Adding provenance=false and sbom=false flags to reduce image complexity and avoid compatibility issues
  • Splitting the matrix to build architecture-specific images with proper -${{ matrix.arch }} suffixes
  • Completely rewriting the manifest creation logic to properly reference architecture-specific images using variables like AMD64_TAG and ARM64_TAG
  • Implementing proper error handling that fails fast when images are not found, rather than silently continuing

This fix ensures that the CI/CD pipeline can successfully create multi-architecture Docker manifests, which is essential for the application's deployment across different CPU architectures. The workflow now properly handles the tag resolution between the build and manifest creation phases.

Confidence score: 4/5

  • This is a well-structured fix that addresses a specific architectural tagging issue in the Docker build process
  • The score reflects confidence in the technical approach, though multi-architecture CI/CD changes can have subtle deployment implications
  • .github/workflows/build.yml needs careful attention due to the significant restructuring of the build matrix and manifest creation logic

1 file reviewed, no comments

Edit Code Review Bot Settings | Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants