-
-
Notifications
You must be signed in to change notification settings - Fork 28.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Full-Text Search #1954
Add Full-Text Search #1954
Conversation
Thanks for making an Awesome list! 🙌 It looks like you didn't read the guidelines closely enough. I noticed multiple things that are not followed. Try going through the list point for point to ensure you follow it. I spent a lot of time creating the guidelines so I wouldn't have to comment on common mistakes, and rather spend my time improving Awesome. |
A couple pointers to help out @Kikobeats :
The best is, well, to just stick to the PR template, I guess :) Hope that helps ! |
@ozh ops you're right, I totally forgot that! How does this sound to you?
Also, I moved to the right category |
The main problem with this list is that it is nowhere close to including all of the great full-text search engines that have been developed. For example, your project does not include Lucene, which is by far the most popular full text search engine, and has been around the longest as well. |
@brianmingus2 most of the items on the list are lucene-like projects |
Hi, it's 26 days since the last comment already and the PR still doesn't fulfill all rules described in PR requirements. Please re-read the requirements and I'd suggest starting from the beginning and re-create the PR that fulfills all rules.
|
Fixed title! |
This repo and rules are just zealotry at their finest. I've given up long ago on getting my own list listed here. |
@ozh I agree – Rules like I can understand why these rules are necessary for a repo with giant dimensions like this, but honestly, they are not working. |
@ozh @Kikobeats I agree with contributing rules but the truth is this guide is very long and it's easy to lose in it. Especially reviewing 2 PRs is a great idea. Worse are the nitpicking rules about formatting. There are many of them. |
Hello,
I added https://github.com/Kikobeats/awesome-full-text-search under the JavaScript section since this is the list I'm maintaining for the last 5 years.
main
.