Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Full-Text Search #1954

Closed
wants to merge 3 commits into from
Closed

Add Full-Text Search #1954

wants to merge 3 commits into from

Conversation

Kikobeats
Copy link
Contributor

@Kikobeats Kikobeats commented Feb 21, 2021

Hello,

I added https://github.com/Kikobeats/awesome-full-text-search under the JavaScript section since this is the list I'm maintaining for the last 5 years.

  • branch name is main.
  • linter is reporting 0 issues.
  • added the item with a description in the right position.

@sindresorhus
Copy link
Owner

Thanks for making an Awesome list! 🙌

It looks like you didn't read the guidelines closely enough. I noticed multiple things that are not followed. Try going through the list point for point to ensure you follow it. I spent a lot of time creating the guidelines so I wouldn't have to comment on common mistakes, and rather spend my time improving Awesome.

@ozh
Copy link

ozh commented Feb 27, 2021

A couple pointers to help out @Kikobeats :

  • you didn't review (at least 2) open PR and state here what your reviews were (point 2 of the PR requirements)
  • you didn't stick to the "short description about the project/theme of the list" guideline (point 5 of the PR reqs)
  • you didn't add your list to the bottom of the appropriate category (point 6 of the PR reqs)

The best is, well, to just stick to the PR template, I guess :)

Hope that helps !

@Kikobeats
Copy link
Contributor Author

Kikobeats commented Mar 9, 2021

@ozh ops you're right, I totally forgot that!

How does this sound to you?

Quickly find all instances of text with in-memory and database solutions.

Also, I moved to the right category

@ghost
Copy link

ghost commented Apr 11, 2021

The main problem with this list is that it is nowhere close to including all of the great full-text search engines that have been developed. For example, your project does not include Lucene, which is by far the most popular full text search engine, and has been around the longest as well.

@Kikobeats
Copy link
Contributor Author

@brianmingus2 most of the items on the list are lucene-like projects

@ghost ghost mentioned this pull request Apr 12, 2021
@prokopsimek
Copy link

Hi, it's 26 days since the last comment already and the PR still doesn't fulfill all rules described in PR requirements.

Please re-read the requirements and I'd suggest starting from the beginning and re-create the PR that fulfills all rules.

  • Your PR title is wrong
  • Your first PR description should be formatted as PR template
  • You have to review 2 more PRs and mention them in your PR description
    ...and many more...

@Kikobeats Kikobeats changed the title Add Full-text search Add Full-Text Search May 8, 2021
@Kikobeats
Copy link
Contributor Author

Fixed title!

@ozh
Copy link

ozh commented May 8, 2021

This repo and rules are just zealotry at their finest. I've given up long ago on getting my own list listed here.

@Kikobeats
Copy link
Contributor Author

@ozh I agree – Rules like You have to review at least 2 other are just adding a lot of noise over PRs with silly comments just to fulfilled the rule.

I can understand why these rules are necessary for a repo with giant dimensions like this, but honestly, they are not working.

@prokopsimek
Copy link

@ozh @Kikobeats I agree with contributing rules but the truth is this guide is very long and it's easy to lose in it. Especially reviewing 2 PRs is a great idea. Worse are the nitpicking rules about formatting. There are many of them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants