-
-
Notifications
You must be signed in to change notification settings - Fork 28.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Chalice #1984
Add Chalice #1984
Conversation
https://github.com/chalice-dev/awesome-chalice#readme This is a list of awesome need-to-knows related to AWS Chalice, a previously hidden gem for writing serverless Python applications on AWS.
unicorn |
Your PR doesn't suffer from most of the mishaps that I see from other awesome lists, but there are a couple things that I picked up on. I'll defer to the repository maintainers for whether it must be changed as I lack experience for judgment here. Take this feedback with a huge grain of salt. From the manifesto, there's this quote:
I think the spirit of that isn't present in a lot of the link descriptions… which read more as descriptions rather than recommendations. For example: I also think that the "Blogs" section may be better titled as "Blog Articles". Again, I'll defer to the actual maintainers of awesome as to whether or not you should also include text on why those blog articles are critical background reading. Hope this is helpful! |
This is an advanced awesome list. Devs will know if they need paid tracing or hard encryption, and why that's awesome (I'm also not seeing that I have to explain what's awesome about hard encryption, which would take a lot of space). The last three sections don't have additional descriptions, because they have descriptive titles. |
For comparison, this is a sister list: https://github.com/kolomied/awesome-cdk |
I think that sister list does a good job of balancing descriptions between why and what. |
Specific examples would help. You highlighted paid tracing. In your opinion, what more should be said about paid tracing? There is free tracing on the list, and the paid tracing options are all worth evaluating. PR's accepted. |
I'll say again that I'm speculating with my feedback. I think @sindresorhus could tell me if I'm off-base and maybe this is ready to merge as-is. I'd imagine that the description should be whatever distinguishes them from each other within the market. In the cdk list, I've highlighted the two lines that were most similar in description: Maybe it's as simple as "A commercial tracing system using <sentry.io>" |
I removed them from the list because I can't include a cost/benefit analysis, which depends on your use-case. Thanks. |
Header: |
The list header looks weird. The top part is right-aligned and then left-aligned. |
Fixed and fixed |
It looks weird to have both a graphic header and also text header saying the same. You should pick one. |
Fixed |
I went with the text header version instead, seems to look much better, than awesome+chalice logos side-by-side. |
https://github.com/chalice-dev/awesome-chalice#readme
Chalice is a framework for writing serverless Python applications on AWS Lambda.
I reviewed:
https://github.com/chalice-dev/awesome-chalice#readme
This is an awesome list of need-to-know links relating to AWS Chalice, a previously hidden gem for writing serverless Python applications on AWS Lambda.
By submitting this pull request I confirm I've read and complied with the below requirements 🖖
Please read it multiple times. I spent a lot of time on these guidelines and most people miss a lot.
Requirements for your pull request
Try to prioritize unreviewed PRs, but you can also add more comments to reviewed PRs. Go through the below list when reviewing. This requirement is meant to help make the Awesome project self-sustaining. Comment here which PRs you reviewed. You're expected to put a good effort into this and to be thorough. Look at previous PR reviews for inspiration. Just commenting “looks good” or simply marking the pull request as approved does not count! You have to actually point out mistakes or improvement suggestions.
Add Name of List
.Add Swift
Add Software Architecture
Update readme.md
Add Awesome Swift
Add swift
add Swift
Adding Swift
Added Swift
- [iOS](…) - Mobile operating system for Apple phones and tablets.
- [Framer](…) - Prototyping interactive UI designs.
- [iOS](…) - Resources and tools for iOS development.
- [Framer](…)
- [Framer](…) - prototyping interactive UI designs
Requirements for your Awesome list
That means 30 days from either the first real commit or when it was open-sourced. Whatever is most recent.
awesome-lint
on your list and fix the reported issues. If there are false-positives or things that cannot/shouldn't be fixed, please report it.main
, notmaster
.Mobile operating system for Apple phones and tablets.
Prototyping interactive UI designs.
Resources and tools for iOS development.
Awesome Framer packages and tools.
If you have not put in considerable effort into your list, your pull request will be immediately closed.
awesome-name-of-list
.awesome-swift
awesome-web-typography
awesome-Swift
AwesomeWebTypography
# Awesome Name of List
.# Awesome Swift
# Awesome Web Typography
# awesome-swift
# AwesomeSwift
awesome-list
&awesome
as GitHub topics. I encourage you to add more relevant topics.Contents
, notTable of Contents
.Contributing
orFootnotes
sections.https://github.com/<user>/<repo>/community/license/new?branch=main&template=cc0-1.0
(replace<user>
and<repo>
accordingly).license
orLICENSE
in the repo root with the license text.Licence
section to the readme. GitHub already shows the license name and link to the full text at the top of the repo.unicorn
.contributing.md
. Casing is up to you.Contributing
, positioned at the top or bottom of the main content.Footnotes
section at the bottom of the readme. The section should not be present in the Table of Contents.Example:
- [AVA](…) - JavaScript test runner.
Node.js
, notNodeJS
ornode.js
.You can still use Travis for list linting, but the badge has no value in the readme.
Inspired by awesome-foo
orInspired by the Awesome project
kinda link at the top of the readme. The Awesome badge is enough.Go to the top and read it again.