Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cwd option #46

Merged
merged 11 commits into from
May 8, 2022
Merged

Add cwd option #46

merged 11 commits into from
May 8, 2022

Conversation

jopemachine
Copy link
Contributor

Fixes #45.

sindresorhus
sindresorhus reviewed Mar 30, 2022
View reviewed changes
index.js Outdated Show resolved Hide resolved
sindresorhus
sindresorhus reviewed Mar 30, 2022
View reviewed changes
index.d.ts Outdated Show resolved Hide resolved
sindresorhus
sindresorhus reviewed Mar 30, 2022
View reviewed changes
test/async.js Outdated Show resolved Hide resolved
sindresorhus
sindresorhus reviewed Mar 30, 2022
View reviewed changes
test/async.js Outdated Show resolved Hide resolved
sindresorhus
sindresorhus reviewed Mar 30, 2022
View reviewed changes
index.js Outdated Show resolved Hide resolved
sindresorhus
sindresorhus reviewed Mar 30, 2022
View reviewed changes
index.d.ts Outdated Show resolved Hide resolved
sindresorhus
sindresorhus reviewed Mar 30, 2022
View reviewed changes
index.js Outdated Show resolved Hide resolved
sindresorhus
sindresorhus reviewed Mar 30, 2022
View reviewed changes
test/sync.js Outdated Show resolved Hide resolved
sindresorhus
sindresorhus reviewed Apr 6, 2022
View reviewed changes
index.d.ts Outdated Show resolved Hide resolved
@sindresorhus
Copy link
Owner

CI is failing

@jopemachine
Copy link
Contributor Author

CI is failing

It seems there are different issues with this.
I will try to make separate PRs handling each issue.

@jopemachine
Copy link
Contributor Author

jopemachine commented Apr 6, 2022 •
edited
Loading

CI is failing

It seems there are different issues with this. I will try to make separate PRs handling each issue.

I made #48, #50. It seems CI issue is likely to be resolved with these.

sindresorhus
sindresorhus reviewed Apr 8, 2022
View reviewed changes
readme.md Outdated Show resolved Hide resolved
@jopemachine
Copy link
Contributor Author

I'm sorry to bother you 🙏
I updated the document trying to clearly elaborate.

sindresorhus
sindresorhus reviewed Apr 18, 2022
View reviewed changes
index.js Outdated Show resolved Hide resolved
sindresorhus
sindresorhus reviewed May 3, 2022
View reviewed changes
index.d.ts Outdated Show resolved Hide resolved
@sindresorhus
Copy link
Owner

It was implied that this applied to the other occurrence of this too: #46 (comment)

@sindresorhus sindresorhus merged commit 3fe6ab4 into sindresorhus:main May 8, 2022
@danielweck danielweck mentioned this pull request Jul 6, 2023
Closed
@danielweck
Copy link

danielweck commented Jul 6, 2023 •
edited
Loading

I believe this PR shipped in cp-file v10 caused a regression in cpy v10 which in turn breaks cpy-cli v5:

sindresorhus/cpy#107 (comment)

(it's a subtle edge case with relative paths and implicit process.cwd(), but it boils down to resolving against options.cwd whereas the correct previous behaviour was to resolve against process.cwd() ... I think the fix must be made on the consumer side of cp-file, i.e. cpy)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sindresorhus sindresorhus sindresorhus left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FR: cwd option
3 participants
@jopemachine @sindresorhus @danielweck