Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI error on Windows #50

Merged
merged 1 commit into from
Apr 7, 2022
Merged

Fix CI error on Windows #50

merged 1 commit into from
Apr 7, 2022

Conversation

jopemachine
Copy link
Contributor

Fixes #49.

@jopemachine jopemachine mentioned this pull request Apr 6, 2022
Merged
@sindresorhus
Copy link
Owner

CI is failing

@sindresorhus
Copy link
Owner

Tip for next time: No need to create an issue first if you intend to submit a pull request.

@jopemachine
Copy link
Contributor Author

jopemachine commented Apr 7, 2022 •
edited
Loading

Tip for next time: No need to create an issue first if you intend to submit a pull request.

Understood. Thanks for your tip :)

CI is failing

This failing is caused by #47. It should be fixed if #48 is merged.
I made 2 different PRs fixing CI yesterday because I consider they are separate issues.
(But on second thought, since this PR is very simple, I think I should've done it within one PR..)

@sindresorhus sindresorhus merged commit 778ecdb into sindresorhus:main Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix is failing on Windows
2 participants
@jopemachine @sindresorhus