Make error messages more consistent #230
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes
error.message
more consistent.execa
errors in the following cases:a) exit code is defined and is not
0
b) child process
error
event, orstdin
error
eventc) signal termination (including
cancel()
)d) timeout
e) stream error (separate issue: #228)
a) c) d) e) look consistent. However b):
stdout
andstderr
, as opposed to the others. This can also lead to unexpectedly (very) long error messages, which might create issues for some users.error.stdout
anderror.stderr
can be used instead.This adjusts b) error message to the same format used by the other errors.
It turns out to cover this, I just had to remove unit tests but did not need to add new ones (could not think of one not already covered).