-
-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v2 release post and changelog #253
Comments
This looks great. Thanks for doing the work. I've added a couple of comments to the Medium draft, but it's already awesome.
This is not really relevant to the user. |
Thanks a lot! When we do the major release, could you please:
|
Do I have We still have few items in the milestone though. |
Yes |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@ehmicky when will the new version be released。expecting... thx |
@lolipop99 thanks for your interest in the new version! We don't have a deadline (like most open source projects). We have a list of items until the release though: you can follow this milestone. |
@sindresorhus |
@magicdawn No. That's just enabling users to not know how things work. I added it to the Got readme because I knew it was going to come up, but I wish I hadn't. People should learn how GitHub works. |
I agree with @sindresorhus that when I get on a GitHub repository which shows different documentation for different versions, I find it a little confusing. Instead I'm always assuming the documentation is of the latest version. Now this assumes versions are released fast, which has not been the case for this major release. The problems are:
|
Awesome work on this! Was trying to use Ya'll rock! Excited for release on |
Cool. Sounds like a big one! 🎉 In the past 2-3 years, I was maintaining And the #153 was the reason to use Waiting for that release for sure! 🌮 |
@tunnckoCore great to hear! Feel free to checkout our implementation for |
Yea, I've seen it, it looks like the same thing, I will try it. |
There's an alpha version of v2 out now: https://github.com/sindresorhus/execa/releases/tag/v2.0.0-alpha.0 Install it with Please share feedback here or in new issues. |
Sweeeet! 🌮 🎉 Works great for now. |
We just released |
CHANNGELOG: sindresorhus/execa#253
CHANNGELOG: sindresorhus/execa#253
CHANNGELOG: sindresorhus/execa#253
CHANNGELOG: sindresorhus/execa#253
CHANNGELOG: sindresorhus/execa#253
I've created a Medium article for the upcoming major release (#191). Feel free to leave private notes on it if you think some sentences should be reworked or something is missing/wrong! It will remain in draft mode until
2.0.0
is published to npm, so please do not promote that link yet.I'm also working on the changelog that we could include as the GitHub release description. I will update this post as new commits come in. Feel free to comment on it as well. Here it is:
Thanks to @GMartigny, @BendingBender, @tomsotte, @ammarbinfaisal, @zokker13, @stroncium, @satyarohith, @bradfordlemley, @coreyfarrell, @brandon93s, @dtinth, @papb for the great features and bug fixes they've contributed!
Please check the Medium article about this release!
Breaking changes
util.getSystemErrorName()
#221)execa.shell()
andexeca.shellSync()
. Theshell
option should be used instead. (Removeexeca.shell()
andexeca.shellSync()
#219)execa.stdout()
andexeca.stderr()
.childProcessResult.stdout
andchildProcessResult.stderr
should be used instead (Removeexeca.stdout()
andexeca.stderr()
#234)error.code
(number
orstring
) in favor oferror.exitCode
(number
) anderror.exitCodeName
(string
) (Distinguishing between error strings and error numbers #187, Removeerror.code
#250)stripeEof
option tostripFinalNewline
(f8397ba9, 4d0dc88a, Remove deprecated optionstripEof
#238)cmd
(inchildProcessResult
anderror
) tocommand
(Rename.cmd
to.command
#194)preferLocal
option tofalse
. If you are executing locally installed binaries, you'll need to manually specifypreferLocal: true
(Change default value of thepreferLocal
option tofalse
#314)windowsHide
option is alwaystrue
, so that no window pops up on Windows. (8c886452)error.signal
is nowundefined
instead ofnull
when no signal was used (Replacenull
byundefined
#193)error.killed
tofalse
when child process timed out (Improveerror.killed
#227)error.killed
always boolean (notundefined
) (Makeerror.killed
anderror.isCanceled
always boolean (notundefined
) #229, Makeerror.killed
more consistent #248)execa()
#276, Fix shape of exceptions thrown byexeca.sync()
#277, Fix tests on Mac #283)error.stdout
anderror.stderr
are now an empty string (instead ofnull
) when the command failed. (Makestdout
andstderr
propertiesundefined
instead ofnull
#246)Features
execa.command()
andexeca.commandSync()
. Those are the same asexeca()
except both file and arguments are specified in a single string. For example,execa('echo', ['unicorns'])
is the same asexeca.command('echo unicorns')
(Support single string input without using theshell
option #182, Addexeca.command()
#261, Fix not being able to escape more than one space in commands #262, RenamejoinedCommand
variables tocommand
#278, Fix documentation aboutresult.command
#279, Fix variable name bug (master
failing) #282)childProcess.all
andchildProcessResult.all
(Add.all
property with interleaved stdout and stderr #171, Upgrademerge-stream
from1.0.1
to2.0.0
#264)execa.node()
which (likechild_process.fork()
) allows you to execute a Node.js script as a child process (Add.node()
method #200, Fix documentation ofexeca.node()
#297, RenamenodeArguments
tonodeOptions
#299, Refactorstdio
option #302, Refactorstdio
option forexeca.node()
#303, Refactor entry point ofexeca.node()
#305, Rename variables instdio
file #306).childProcess.kill()
does not terminate a child process after 5 seconds, force it by sendingSIGKILL
. This can be configured using theforceKillAfterTimeout
option. (Add feature to retry process killing after specified duration #208, Refactorkill()
#272, Removetry
/catch
insidekill()
#273, Refactorkill()
again #280, Refactor tests ofkill()
#284, MergeforceKill
andforceKillAfter
options #285)childProcess.cancel()
anderror.isCanceled
(Make the spawned process cancelable #189, f24e7c72, Simplifycancel()
method #226, Improve/refactor.cancel()
#309)error.stdout
,error.stderr
anderror.all
now contain the data that was sent before the child process exit. (Add buffered data toerror.stdout
,error.stderr
anderror.all
#271)error.message
on child process failure (Improve returnederror.message
#180, Remove dead code related to exit code names #223, Make error messages more consistent #230, Separate original error message with a newline #245, Improve error messages when anerror
event is emitted #269).finally()
to the child process promise (Make the Promise interface complete by adding a.finally()
method #174, 65139849)maxBuffer
option default value from10 MB
to100 MB
(ChangemaxBuffer
default value from10 MB
to100 MB
#286)Bug fixes
timeout
option not working as expected (Fix timeout option not leaving early when onsleep
mode #199)error.timedOut
not working withexeca.sync()
(Fixerror.timedOut
not working withexeca.sync()
#249)maxBuffer
errors not using the same shape as the other errors (Make errors more consistent #266)extendEnd
option not working withshell
option (FixextendEnv
option not working withshell
option #184)stripFinalNewline
option not applied on error properties (FixstripFinalNewline
not applied onerror.stdout|stderr|all
#240)/q
parameter not added when usingcmd
instead ofcmd.exe
(Add/q
option tocmd
as well ascmd.exe
on Windows #203)input
option with a non-executable file (Fix non-executable execution withinput
option #212, Add TODO comment aboutspawned.stdin
bug being fixed in Node.js 12 #258)stdio
option cannot be used together withstdin: 0
(Do not allowstdin: 0
combined withstdio
#301).Documentation
encoding: null
#158, Improve a readme example #235, Improve readmeWhy
section #237, Improve the API section of the readme #239, Reorder properties of results and errors #241, Separate core options from execa-specific options #256)Design
Tests
shell
option #185, Fixoptions.detached
test #215, Improve test foroptions.preferLocal
#216, Fix test foroptions.cleanup
#224, Fix test foroptions.localDir
#218, Improvecleanup
option (code quality, tests, documentation) #225, Fix randomly failing CI tests #231, Improve tests for thereject
option #233, Make tests more consistent (code refactoring) #247, Simplify tests for stdio #300)Maintainers
The text was updated successfully, but these errors were encountered: