Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix not being able to escape more than one space in commands #262

Merged
merged 4 commits into from
May 22, 2019
Merged

Fix not being able to escape more than one space in commands #262

merged 4 commits into from
May 22, 2019

Conversation

ehmicky
Copy link
Collaborator

@ehmicky ehmicky commented May 21, 2019

execa('path\\ space') works, but not execa('path\\ with\\ multiple\\ spaces'). This PR fixes this.

@ehmicky ehmicky mentioned this pull request May 21, 2019
Merged
GMartigny
GMartigny reviewed May 21, 2019
View reviewed changes
index.js Outdated Show resolved Hide resolved
@GMartigny
Copy link
Contributor

Looks good

@sindresorhus sindresorhus merged commit dd63573 into master May 22, 2019
@sindresorhus sindresorhus deleted the features/fix-spaces-escaping branch May 22, 2019 14:22
@ehmicky ehmicky mentioned this pull request May 22, 2019
Closed
@dependabot dependabot bot mentioned this pull request Mar 14, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GMartigny GMartigny GMartigny left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ehmicky @GMartigny @sindresorhus