Rename nodeArguments to nodeOptions
#299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehmicky
force-pushed
the
feature/execa-node-options
branch
from
9d079c4 to
19e1955
Compare
ehmicky
force-pushed
the
feature/execa-node-options
branch
from
19e1955 to
3e8cda0
Compare
|
Yes, agreed 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the name
nodeArgumentsmakes it unclear it's about Node CLI flags, as opposed to the arguments passed tonode scriptPath.js ....Also this makes it more consistent with the way Node.js calls it in the documentation.
@GMartigny