Support overloaded functions (TypeScript types) #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fregante
force-pushed
the
support-overloaded-functions
branch
from
d906fdc
to
2c253ca
Compare
fregante
force-pushed
the
support-overloaded-functions
branch
from
2c253ca
to
77a2a2d
Compare
|
cc @BendingBender to possibly double-check |
We are testing that the types of `mem(fn)` are identical to `fn`’s after all
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #46
The problem was that the input function was being broken into
...ArgumentsandReturnTypeand then recomposed asmem’s return. This apparently picked up just one of the overloads and discarded the rest.I tested this in Refined GitHub and it fixed my problems: https://github.com/sindresorhus/refined-github/pull/2545/files#diff-98a7886093e2e560968c34d6c4707b22L24-L29