Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generating invalid locale #28

Closed
Stanzilla opened this issue Jun 21, 2018 · 0 comments · Fixed by #33
Closed

Generating invalid locale #28

Stanzilla opened this issue Jun 21, 2018 · 0 comments · Fixed by #33

Comments

@Stanzilla
Copy link

See vercel/hyper#3091

It looks like if people have their region set to one country and the display language to another, os-locale generates a invalid xx_xx pair, not sure if this should be validated in the lib or the app using it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Validate AppleLocale against supported locales pi0/os-locale
1 participant
@Stanzilla