-
-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate AppleLocale
against supported locales
#33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pi0
changed the title
fix: validate AppleLocale
fix: validate AppleLocale against supported locales
Dec 16, 2018
2 tasks
@sindresorhus Tests seem to fail on master too. Opened #34 for it. |
Stanzilla
approved these changes
Dec 22, 2018
sindresorhus
requested changes
Dec 26, 2018
Can you fix the merge conflict? |
@sindresorhus Thanks for time for review. I made changes and also added a comment. |
sindresorhus
approved these changes
Dec 26, 2018
sindresorhus
changed the title
fix: validate AppleLocale against supported locales
Validate Dec 26, 2018
AppleLocale
against supported locales
pi0
added a commit
to pi0/hyper
that referenced
this pull request
Dec 26, 2018
Stanzilla
pushed a commit
to vercel/hyper
that referenced
this pull request
Jan 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #28, vercel/hyper#3091, and vercel/hyper#2913 (comment).
MacOS
defaults read -g AppleLocale
returns invalid POSIX values when the locale is different than language, causing values likeen_DE
oren_IR
. Fortunately, we also have/usr/bin/locale -a
which returns a list of supported locales.This PR fixes issue, by validating locale against supporting locales and falling back to the
defaultLocale
in case of invalid one.Attachment. Perl warning: