-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set the lang env by using os-locale #2913
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is ready to merge, we had LGTM in the old PR, same code just the dep added.
This is causing warns when my locale is not en_US: MacOS Mojave
The current workaround is manually set {
env: {
LANGUAGE: 'en_US.UTF-8',
LC_ALL: 'en_US.UTF-8',
LANG: 'en_US.UTF-8',
LC_TYPE: 'en_US.UTF-8',
},
} |
More investigations: os-locale will use |
This is #605 rebased and @leo's comment addressed.
I tested that it still works correctly on en_US