Drop unnecessary binding

[fregante]

this here is always window/global, which means that if the functions actually use this, they will refer to window/global… which is the default.

Am I missing something?

Edit: I suppose this was just to apply the parameters before the spread operator became available.

[sindresorhus]

Edit: I suppose this was just to apply the parameters before the spread operator became available.

Correct

[darcyparker]

I just traced a bug in my code to this change that dropped the unnecessary binding. I think it should be reconsidered and reverted because I'd argue it is necessary is some contexts.

It is true that this always globalThis/window IF the setTimeout() argument was a function. But its not a function - it is an arrow function. this should be the same this of the returned function (https://github.com/sindresorhus/p-debounce/blob/master/index.js#L12)

Consider:

class Something {
  private abc: string = '123'
   fn() {
     console.log(this.abc);
   }
}

Something.prototype.fn = debounce(Something.prototype.fn, 100);
const b = new Something();
b.fn(); //An error will be thrown with this pull request's change because `this` is not `b` instance.

In this case the debounced Something.prototype.fn, this should not be globalThis.

Would you agree? And would you consider a pull request that adds unit test along the lines of my example?

[darcyparker]

See #16
Thanks for reviewing my comment and giving thumbs up @fregante