Fix regression with preserving this context
#16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
darcyparker
force-pushed
the
revertPull12
branch
from
fe8d0c9 to
10cf498
Compare
darcyparker
added a commit
to darcyparker/p-throttle
that referenced
this pull request
Jan 20, 2021
* This is to protect against a mistake like sindresorhus/p-debounce#12 (comment) * Similar to sindresorhus/p-debounce#16, but for pThrottle.
fregante
reviewed
Jan 20, 2021
* This reverts sindresorhus#12 * And it addresses same problem with pDebounce.promise() implementation added in sindresorhus#13
darcyparker
force-pushed
the
revertPull12
branch
from
95b4314 to
2f734f5
Compare
darcyparker
force-pushed
the
revertPull12
branch
from
ba025e6 to
ca158b8
Compare
similar pull request for `p-throttle`. sindresorhus/p-throttle#25
sindresorhus
changed the title
this context
|
Thanks for fixing this :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #12 (comment)