TDL-20356 update function based to class based #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ub.com/singer-io/tap-freshdesk into TDL-20356-update-function-based-to-class-based
namrata270998
changed the base branch from
crest-master
to
TDL-20357-add-missing-tap-tester-tests
namrata270998
requested review from
dbshah1212,
karanpanchal-crest and
savan-chovatiya
…ub.com/singer-io/tap-freshdesk into TDL-20356-update-function-based-to-class-based
dbshah1212
reviewed
Aug 26, 2022
…s://github.com/singer-io/tap-freshdesk into TDL-20356-update-function-based-to-class-based
tap_freshdesk/client.py
Outdated
| BASE_URL = "https://{}.freshdesk.com" | ||
|
|
||
|
|
||
| def ratelimit(limit, every): |
There was a problem hiding this comment.
This function is already present under singer-python, so please import it and use it directly.
Reference: https://github.com/singer-io/singer-python/blob/master/singer/utils.py#L81-L99
There was a problem hiding this comment.
Removed the defined function from the tap and used the pre-defined singer functions for rate limit
dbshah1212
reviewed
Sep 2, 2022
dbshah1212
reviewed
Sep 2, 2022
savan-chovatiya
approved these changes
Sep 7, 2022
dbshah1212
reviewed
Sep 8, 2022
dbshah1212
approved these changes
Sep 15, 2022
…-tests' into TDL-20356-update-function-based-to-class-based
…update-function-based-to-class-based
sgandhi1311
reviewed
Sep 26, 2022
| This function will get page size from config, | ||
| and will return the default value if an invalid page size is given. | ||
| """ | ||
| page_size = self.config.get('page_size') |
There was a problem hiding this comment.
Suggested change
| page_size = self.config.get('page_size') | |
| page_size = self.config.get('page_size', DEFAULT_PAGE_SIZE) |
We can remove the below condition -
if page_size is None: return DEFAULT_PAGE_SIZE
sgandhi1311
reviewed
Sep 26, 2022
| expected_list_3 = [{"name": "Agency", "value": "justice league"}, | ||
| {"name": "Department", "value": "superhero"}] | ||
|
|
||
| @ parameterized.expand([ |
There was a problem hiding this comment.
Suggested change
| @ parameterized.expand([ | |
| @parameterized.expand([ |
Typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Manual QA steps
Risks
Rollback steps