Tdl 12262 add ticket fields stream #52
Conversation
…L-12262-add-ticket_fields-stream
…L-12262-add-ticket_fields-stream
…L-12262-add-ticket_fields-stream
tests/test_freshdesk_pagination.py
Outdated
| @@ -43,7 +43,7 @@ def test_run(self): | |||
| with self.subTest(stream=stream): | |||
| # Not able to generate more data as roles stream requires pro account. | |||
| # So, updating page_sie according to data available. | |||
| if stream == "roles": | |||
| if stream == "roles" or stream == "ticket_fields": | |||
There was a problem hiding this comment.
| if stream == "roles" or stream == "ticket_fields": | |
| if stream in ["roles", "ticket_fields"]: |
tests/test_freshdesk_pagination.py
Outdated
| if stream in ["roles", "ticket_fields"]: | ||
| page_size = 2 |
There was a problem hiding this comment.
Where are we setting page_size=2 in the test? I could not find it in get_properties()
There was a problem hiding this comment.
We are setting page_size property in the base.py. It was added in the PR#51 and we have raised this pr from it. Back merge remained and that's why this change was not reflected here.
…L-12262-add-ticket_fields-stream
…L-12262-add-ticket_fields-stream
tests/test_freshdesk_start_date.py
Outdated
| expected_streams = self.expected_streams() | ||
|
|
||
| # To collect "time_entries", "satisfaction_ratings" pro account is needed. Skipping them for now. | ||
| expected_streams = expected_streams - {'satisfaction_ratings', 'time_entries'} |
There was a problem hiding this comment.
Can we merge these two separate lines into one?
expected_streams = self.expected_streams() - {'satisfaction_ratings', 'time_entries'}There was a problem hiding this comment.
Merged mentioned two lines to reduce redundancy.
| "portal_cc_to": { | ||
| "type": ["null", "string"] | ||
| }, | ||
| "choices": {}, |
There was a problem hiding this comment.
Why the type is not mentioned for choices?
There was a problem hiding this comment.
As per the Freshdesk API documentation, choices is the list of values. But, in the actual response, we observed different types of values including a list of strings, plain object(dict), an object of the list, etc. That's why due to uncertainty in the value of this field, we kept {} as datatype and generally we keep {} in such cases.
tests/test_freshdesk_start_date.py
Outdated
| @@ -14,6 +14,21 @@ def name(): | |||
| return "tap_tester_freshdesk_start_date_test" | |||
|
|
|||
| def test_run(self): | |||
| # Streams to verify start date tests | |||
There was a problem hiding this comment.
Added docstring to describe the test_run function.
Description of change
ticket_fields.ticket_fields.Manual QA steps
Risks
Rollback steps