TDL-19959 added missing fields #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ub.com/singer-io/tap-typeform into TDL-19957-update-dict-based-to-class-based
…ub.com/singer-io/tap-typeform into TDL-19957-update-dict-based-to-class-based
…ub.com/singer-io/tap-typeform into TDL-19957-update-dict-based-to-class-based
…github.com/singer-io/tap-typeform into TDL-19957-update-dict-based-to-class-based
…ub.com/singer-io/tap-typeform into TDL-19957-update-dict-based-to-class-based
…ub.com/singer-io/tap-typeform into TDL-19957-update-dict-based-to-class-based
…ub.com/singer-io/tap-typeform into TDL-19957-update-dict-based-to-class-based
…github.com/singer-io/tap-typeform into TDL-19959-add-missing-fields
…ub.com/singer-io/tap-typeform into TDL-19957-update-dict-based-to-class-based
…github.com/singer-io/tap-typeform into TDL-19959-add-missing-fields
savan-chovatiya
approved these changes
Aug 2, 2022
dbshah1212
approved these changes
Aug 3, 2022
…ub.com/singer-io/tap-typeform into TDL-19957-update-dict-based-to-class-based
…github.com/singer-io/tap-typeform into TDL-19959-add-missing-fields
prijendev
changed the base branch from
TDL-19957-update-dict-based-to-class-based
to
crest-master
RushiT0122
requested changes
Sep 2, 2022
Comment on lines
75
to
76
| self.assertTrue(expected_automatic_keys.issubset( | ||
| expected_all_keys), msg='{} is not in "expected_all_keys"'.format(expected_automatic_keys-expected_all_keys)) |
There was a problem hiding this comment.
This assertion is duplicated on L#88, remove one of the assertion.
There was a problem hiding this comment.
Removed duplicate assertion.
RushiT0122
approved these changes
Sep 2, 2022
Merged
somethingmorerelevant
pushed a commit
that referenced
this pull request
Sep 20, 2022
* Tdl 19964 add missing tap tester tests (#65) * TDL-19964 Added missing tap-tester commits * updated tap-tester tests * updated bookmarks tap-tester test * Updated and removed extra comments * updated start date as per format * updated pagination test case * resolved review comments * added new stream in tap-tester * fixed the cci issues * added missing assertion for all fields * removed get_logger() * added logger instead of print * TDL-19957 Update dict based to class based implementation (#64) * TDL-19957 update dict based to class based * updated while condition * updated while condition * removed incremental_range from REQUIRED_CONFIG_KEYS * updated discover and schema file * updated to replication_key instead of keys * updated schemas and added comments * added unittests for code coverage * added unittests for sync.py * added parameterized in setup.py * added parameterized in config.yml and updated unittests * updated the replication key to list instead of a single key * fixed the issue for Keyerror of form_id in answers stream * updated unittests * added configurable page size param * handled page_size for 0 and updated unittests * resolved bug fixes for pagination and removed incompleted_forms_only param * added new stream unsubmitted landings * resolved PR review comments * added page_size in example config * added back incremental_range in the tap-tester * raised exc instead of fatal error message and updated unittests * resolved PR comments * fixed the issue when page_size not passed in config * TDL-19801: Tap fetch data for sub-questions (#62) * TDL-19801: Tap does not support fetching data for the questions nested within a Question Group. * addressed the comments * add unittest * modify funciton comment * formated test_case value in unittest * formated expected_case * Updated schema in questions.json * resolved build fail error * resolve build fail error * updated unittest * updated setup.py * add parameterized * change start date in start_date_test * make change in bookmark test * Updated unit test case. * Updated schemas and keyerror. Co-authored-by: Jay Tilala <jay.tilala@CDSYS.LOCAL> Co-authored-by: prijendev <prijen.khokhani@crestdatasys.com> * TDL-19959 added missing fields (#63) * added missing fields * TDL-19957 update dict based to class based * updated while condition * updated while condition * removed incremental_range from REQUIRED_CONFIG_KEYS * TDL-19964 Added missing tap-tester commits * updated discover and schema file * updated tap-tester tests * updated to replication_key instead of keys * updated schemas and added comments * added unittests for code coverage * updated bookmarks tap-tester test * added unittests for sync.py * added parameterized in setup.py * added parameterized in config.yml and updated unittests * updated the replication key to list instead of a single key * Updated and removed extra comments * fixed the issue for Keyerror of form_id in answers stream * updated unittests * updated start date as per format * added configurable page size param * updated pagination test case * handled page_size for 0 and updated unittests * resolved review comments * resolved bug fixes for pagination and removed incompleted_forms_only param * updated array type schema * added new stream unsubmitted landings * added new stream in tap-tester * updated indentation * resolved PR review comments * updated indentation to use 2 spaces * added page_size in example config * added back incremental_range in the tap-tester * fixed the cci issues * added missing fields to a dict * added missing assertion for all fields * updated comment * raised exc instead of fatal error message and updated unittests * removed get_logger() * added logger instead of print * Updated schema for questions. * Removed duplicate assertion in all_fields test. Co-authored-by: prijendev <prijen.khokhani@crestdatasys.com> * Updated schema for answers stream. Co-authored-by: namrata270998 <75604662+namrata270998@users.noreply.github.com> Co-authored-by: jtilala <104966482+jtilala@users.noreply.github.com> Co-authored-by: Jay Tilala <jay.tilala@CDSYS.LOCAL>
nitingaikwad1
pushed a commit
that referenced
this pull request
Sep 29, 2022
* Tdl 19964 add missing tap tester tests (#65) * TDL-19964 Added missing tap-tester commits * updated tap-tester tests * updated bookmarks tap-tester test * Updated and removed extra comments * updated start date as per format * updated pagination test case * resolved review comments * added new stream in tap-tester * fixed the cci issues * added missing assertion for all fields * removed get_logger() * added logger instead of print * TDL-19957 Update dict based to class based implementation (#64) * TDL-19957 update dict based to class based * updated while condition * updated while condition * removed incremental_range from REQUIRED_CONFIG_KEYS * updated discover and schema file * updated to replication_key instead of keys * updated schemas and added comments * added unittests for code coverage * added unittests for sync.py * added parameterized in setup.py * added parameterized in config.yml and updated unittests * updated the replication key to list instead of a single key * fixed the issue for Keyerror of form_id in answers stream * updated unittests * added configurable page size param * handled page_size for 0 and updated unittests * resolved bug fixes for pagination and removed incompleted_forms_only param * added new stream unsubmitted landings * resolved PR review comments * added page_size in example config * added back incremental_range in the tap-tester * raised exc instead of fatal error message and updated unittests * resolved PR comments * fixed the issue when page_size not passed in config * TDL-19801: Tap fetch data for sub-questions (#62) * TDL-19801: Tap does not support fetching data for the questions nested within a Question Group. * addressed the comments * add unittest * modify funciton comment * formated test_case value in unittest * formated expected_case * Updated schema in questions.json * resolved build fail error * resolve build fail error * updated unittest * updated setup.py * add parameterized * change start date in start_date_test * make change in bookmark test * Updated unit test case. * Updated schemas and keyerror. Co-authored-by: Jay Tilala <jay.tilala@CDSYS.LOCAL> Co-authored-by: prijendev <prijen.khokhani@crestdatasys.com> * TDL-19959 added missing fields (#63) * added missing fields * TDL-19957 update dict based to class based * updated while condition * updated while condition * removed incremental_range from REQUIRED_CONFIG_KEYS * TDL-19964 Added missing tap-tester commits * updated discover and schema file * updated tap-tester tests * updated to replication_key instead of keys * updated schemas and added comments * added unittests for code coverage * updated bookmarks tap-tester test * added unittests for sync.py * added parameterized in setup.py * added parameterized in config.yml and updated unittests * updated the replication key to list instead of a single key * Updated and removed extra comments * fixed the issue for Keyerror of form_id in answers stream * updated unittests * updated start date as per format * added configurable page size param * updated pagination test case * handled page_size for 0 and updated unittests * resolved review comments * resolved bug fixes for pagination and removed incompleted_forms_only param * updated array type schema * added new stream unsubmitted landings * added new stream in tap-tester * updated indentation * resolved PR review comments * updated indentation to use 2 spaces * added page_size in example config * added back incremental_range in the tap-tester * fixed the cci issues * added missing fields to a dict * added missing assertion for all fields * updated comment * raised exc instead of fatal error message and updated unittests * removed get_logger() * added logger instead of print * Updated schema for questions. * Removed duplicate assertion in all_fields test. Co-authored-by: prijendev <prijen.khokhani@crestdatasys.com> * Updated schema for answers stream. * update version and changelog * changelog update for v2.0.0 * changelog update for v2.0.0 * minor changelog update Co-authored-by: namrata270998 <75604662+namrata270998@users.noreply.github.com> Co-authored-by: jtilala <104966482+jtilala@users.noreply.github.com> Co-authored-by: Jay Tilala <jay.tilala@CDSYS.LOCAL> Co-authored-by: prijendev <prijen.khokhani@crestdatasys.com> Co-authored-by: kethan1122 <kcherukuri@talend.com> Co-authored-by: rdeshmukh15 <107538720+rdeshmukh15@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Manual QA steps
Risks
Rollback steps