TDL-19959 added missing fields

tap_typeform/schemas/forms.json

@@ -5,88 +5,53 @@
   ],
   "properties": {
     "id": {
-      "type": [
-        "null",
-        "string"
-      ]
+      "type": ["null", "string"]
     },
     "type": {
-      "type": [
-        "null",
-        "string"
-      ]
+      "type": ["null", "string"]
     },
     "title": {
-      "type": [
-        "null",
-        "string"
-      ]
+      "type": ["null", "string"]
     },
     "last_updated_at": {
-      "type": [
-        "null",
-        "string"
-      ]
+      "type": ["null", "string"]
+    },
+    "created_at": {
+      "type": ["null", "string"],
+      "format": "date-time"
     },
     "settings": {
-      "type": [
-        "null",
-        "object"
-      ],
+      "type": ["null", "object"],
       "properties": {
         "is_public": {
-          "type": [
-            "null",
-            "boolean"
-          ]
+          "type": ["null", "boolean"]
         },
         "is_trial": {
-          "type": [
-            "null",
-            "boolean"
-          ]
+          "type": ["null", "boolean"]
         }
       }
     },
     "self": {
-      "type": [
-        "null",
-        "object"
-      ],
+      "type": ["null", "object"],
       "properties": {
         "href": {
-          "type": [
-            "null",
-            "string"
-          ]
+          "type": ["null", "string"]
         }
       }
     },
     "theme": {
-      "type": [
-        "null",
-        "object"
-      ],
+      "type": ["null", "object"],
       "properties": {
         "href": {
-          "type": [
-            "null",
-            "string"
-          ]
+          "type": ["null", "string"]
         }
       }
     },
     "_links": {
-      "type": [
-        "null",
-        "object"
-      ],
+      "type": ["null", "object"],
       "properties": {
         "display": {
-          "type": [
-            "null",
-            "string"
-          ]
+          "type": ["null", "string"]
         }
       }
     }

tap_typeform/schemas/questions.json

@@ -1,36 +1,234 @@
 {
-    "type": ["null", "object"],
-    "additionalProperties": false,
-    "properties": {
-	"form_id": {
-	    "type": ["null", "string"]
-	},
-	"question_id": {
-	    "type": ["null", "string"]
-	},
-      	"title": {
+  "type": ["null", "object"],
+  "additionalProperties": false,
+  "properties": {
+  "form_id": {
+      "type": ["null", "string"]
+  },
+  "question_id": {
+      "type": ["null", "string"]
+  },
+        "title": {
+            "type": ["null", "string"]
+  },
+        "ref": {
             "type": ["null", "string"]
-	},
-      	"ref": {
+  },
+  "sub_questions": {
+    "type": ["null", "array"],
+    "items": {
+      "type": ["null", "object"],
+      "properties": {
+        "question_id": {
+          "type": ["null", "string"]
+        },
+        "title": {
+          "type": ["null", "string"]
+        },
+        "ref": {
+          "type": ["null", "string"]
+        }
+      }
+    }
+    },
+    "attachment": {
+      "type": ["null", "object"],
+      "properties": {
+        "type": {
+          "type": ["null", "string"]
+        },
+        "href": {
+          "type": ["null", "string"]
+        },
+        "scale": {
+          "type": ["null", "number"]
+        },
+        "properties": {
+          "type": ["null", "object"],
+          "properties": {
+            "description": {
+              "type": ["null", "string"]
+            }
+          }
+        }
+      }
+    },
+    "field_type": {
+      "type": ["null", "string"]
+    },
+    "id": {
+      "type": ["null", "string"]
+    },
+    "layout": {
+      "type": ["null", "object"],
+      "properties": {
+        "type": {
+          "type": ["null", "string"]
+        },
+        "placement": {
+          "type": ["null", "string"]
+        },
+        "attachment": {
+          "type": ["null", "object"],
+          "properties": {
+            "type": {
+              "type": ["null", "string"]
+            },
+            "href": {
+              "type": ["null", "string"]
+            },
+            "scale": {
+              "type": ["null", "number"]
+            },
+            "properties": {
+              "type": ["null", "object"],
+              "properties": {
+                "description": {
+                  "type": ["null", "string"]
+                }
+              }
+            }
+          }
+        }
+      }
+    },
+    "name": {
+      "type": ["null", "string"]
+    },
+    "options": {
+      "type": ["null", "array"],
+      "items": {
+        "type": ["null", "object"],
+        "properties": {
+          "label": {
             "type": ["null", "string"]
-	},
-	"sub_questions": {
-		"type": ["null", "array"],
-		"items": {
-			"type": ["null", "object"],
-			"properties": {
-				"question_id": {
-					"type": ["null", "string"]
-				},
-				"title": {
-					"type": ["null", "string"]
-				},
-				"ref": {
-					"type": ["null", "string"]
-				}
-			}
-		}
+          }
+        }
+      }
+    },
+    "properties": {
+      "type": ["null", "object"],
+      "properties": {
+        "allow_multiple_selection": {
+          "type": ["null", "boolean"]
+        },
+        "allow_other_choice": {
+          "type": ["null", "boolean"]
+        },
+        "alphabetical_order": {
+          "type": ["null", "boolean"]
+        },
+        "button_text": {
+          "type": ["null", "string"]
+        },
+        "choices": {
+          "type": ["null", "array"],
+          "items": {
+            "type": ["null", "object"],
+            "properties": {
+              "attachment": {
+                "type": ["null", "object"],
+                "properties": {
+                  "href": {
+                    "type": ["null", "string"]
+                  },
+                  "type": {
+                    "type": ["null", "string"]
+                  }
+                }
+              },
+              "label": {
+                "type": ["null", "string"]
+              },
+              "ref": {
+                "type": ["null", "string"]
+              }
+            }
+          }
+        },
+        "currency": {
+          "type": ["null", "string"]
+        },
+        "default_country_code": {
+          "type": ["null", "string"]
+        },
+        "description": {
+          "type": ["null", "string"]
+        },
+        "fields": {
+          "type": ["null", "array"],
+          "items": {
+            "type": ["null", "object"]
+          }
+        },
+        "hide_marks": {
+          "type": ["null", "boolean"]
+        },
+        "labels": {
+          "type": ["null", "object"],
+          "properties": {
+            "center": {
+              "type": ["null", "string"]
+            },
+            "left": {
+              "type": ["null", "string"]
+            },
+            "right": {
+              "type": ["null", "string"]
+            }
+          }
+        },
+        "price": {
+          "type": ["null", "object"],
+          "properties": {
+            "type": {
+              "type": ["null", "string"]
+            },
+            "value": {
+              "type": ["null", "string"]
+            }
+          }
+        },
+        "randomize": {
+          "type": ["null", "boolean"]
+        },
+        "separator": {
+          "type": ["null", "string"]
+        },
+        "shape": {
+          "type": ["null", "string"]
+        }
+      }
+    },
+    "required": {
+      "type": ["null", "string"]
+    },
+    "type": {
+      "type": ["null", "string"]
+    },
+    "validations": {
+      "type": ["null", "object"],
+      "properties": {
+        "max_length": {
+          "type": ["null", "integer"]
+        },
+        "max_selection": {
+          "type": ["null", "integer"]
+        },
+        "max_value": {
+          "type": ["null", "integer"]
+        },
+        "min_selection": {
+          "type": ["null", "integer"]
+        },
+        "min_value": {
+          "type": ["null", "integer"]
+        },
+        "required": {
+          "type": ["null", "boolean"]
+        }
+      }
     }
-},
+  },
 "key_properties": ["form_id","question_id"]
 }

tests/test_typeform_all_fields.py

@@ -3,6 +3,15 @@
 import tap_tester.menagerie as menagerie
 from base import TypeformBaseTest
 
+# As we are not able to generate following fields by Typeform UI, so removed them from expectation list.
+KNOWN_MISSING_FIELDS = {
+    'questions': {
+        'name',
+        'field_type',
+        'required',
+        'options'
+    }
+}
 
 class TypeformAllFieldsTest(TypeformBaseTest):
     """Ensure running the tap with all streams and fields selected results in the replication of all fields."""
@@ -66,6 +75,7 @@ def test_run(self):
                 self.assertTrue(expected_automatic_keys.issubset(
                     expected_all_keys), msg='{} is not in "expected_all_keys"'.format(expected_automatic_keys-expected_all_keys))
 
+                expected_all_keys = expected_all_keys - KNOWN_MISSING_FIELDS.get(stream, set())
                 messages = synced_records.get(stream)
                 # Collect actual values
                 actual_all_keys = set()