Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.5.4: Log request URL, etag, and request ID for debugging purposes #63

Merged
merged 3 commits into from
Sep 7, 2021

Conversation

dmosorast
Copy link
Contributor

Description of change

This PR adds logging around every request of the URL, the response ETag, and the Request ID in order to pass these values along to Zendesk support in the event of an error.

Manual QA steps

  • Relying on tests to run a sync for every stream
  • Manually tested with the Users stream to confirm no sensitive information is logged

Risks

  • Low, it's a logging add that's relatively safe (credentials should not be part of the URL string, these are contained within the session itself)

Rollback steps

  • revert this branch

@dmosorast dmosorast changed the title Log request URL, etag, and request ID for debugging purposes v1.5.4: Log request URL, etag, and request ID for debugging purposes Sep 3, 2021
@dmosorast dmosorast merged commit 8abf29e into master Sep 7, 2021
@dmosorast dmosorast deleted the adding-request-logging branch September 7, 2021 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants