Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.5.4: Log request URL, etag, and request ID for debugging purposes #63

Merged
merged 3 commits into from
Sep 7, 2021
Merged

v1.5.4: Log request URL, etag, and request ID for debugging purposes #63

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
04f0aa2
Log request URL, etag, and request ID for debugging purposes
dmosorast Sep 3, 2021
bc81b70
Verswion 1.5.4 and changelog
dmosorast Sep 3, 2021
2710df5
Use safe get on headers. Cases-insensitive does not mean presence-ins…
dmosorast Sep 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
# Changelog

## 1.5.4
* Log Request URL (and URL params), Response ETag, and Response 'X-Request-Id' header to help with troubleshooting [#63](https://github.com/singer-io/tap-zendesk/pull/63)

## 1.5.3
* Break out of infinite loop with users stream and bookmark on date window end [#46](https://github.com/singer-io/tap-zendesk/pull/46)

Expand Down
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
from setuptools import setup

setup(name='tap-zendesk',
version='1.5.3',
version='1.5.4',
description='Singer.io tap for extracting data from the Zendesk API',
author='Stitch',
url='https://singer.io',
Expand Down
7 changes: 6 additions & 1 deletion tap_zendesk/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,12 @@

def request_metrics_patch(self, method, url, **kwargs):
with singer_metrics.http_request_timer(None):
return request(self, method, url, **kwargs)
response = request(self, method, url, **kwargs)
LOGGER.info("Request: %s, Response ETag: %s, Request Id: %s",
url,
response.headers.get('ETag', 'Not present'),
response.headers.get('X-Request-Id', 'Not present'))
return response

Session.request = request_metrics_patch
# end patch
Expand Down