-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use cursor based pagination #64
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@luandy64 Should probably update the PR text to more accurately describe whats happening now. |
LGTM, but I cannot approve as I opened the PR. |
luandy64
approved these changes
Sep 14, 2021
This was referenced Sep 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Changes in this PR:
setup.py
a"test"
extra_requires
so that CI doesn't have to installipdb
setup.py
dependencies onbackoff
andrequests
Organizations
,Satisfaction Ratings
,Ticket Fields
,Tags
, andGroupMemberships
streamssinger-python
from5.2.1
to5.12.2
zenpy
from2.0.0
to2.0.24
Organizations
,Satisfaction Ratings
,Ticket Fields
,Tags
,GroupMemberships
, andTickets
to use cursor-based paginationTickets
leans onzenpy
to do paginationUsers
,Tags
, andGroupMemberships
do not"test"
dependencies instead of"dev"
Manual QA steps
Risks
Rollback steps